[PATCH] Documentation: dt-bindings: leds: document 'default-on' trigger

[PATCH] Documentation: dt-bindings: leds: document 'default-on' trigger

[Roland Hieber]

The default-on trigger has been supported in barebox since commit
767c6b4a814a2a000f3b (2014-02-28, Sascha Hauer: "led: Add default-on
trigger").

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 Documentation/devicetree/bindings/leds/common.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/common.rst b/Documentation/devicetree/bindings/leds/common.rst
index 09b4e401bc2c..ad94ceb506b1 100644
--- a/Documentation/devicetree/bindings/leds/common.rst
+++ b/Documentation/devicetree/bindings/leds/common.rst
@@ -9,6 +9,7 @@ Common leds properties
     * ``net`` - LED indicates network activity (tx and rx)
     * ``net-rx`` - LED indicates network activity (rx only)
     * ``net-tx`` - LED indicates network activity (tx only)
+    * ``default-on`` – LED is switched on by default
 
 * ``label``: The label for this LED. If omitted, the label is taken
   from the node name (excluding the unit address).
-- 
2.39.2

Re: [PATCH] Documentation: dt-bindings: leds: document 'default-on' trigger

[Ulrich Ölmann]

Hi Roland,

On Tue, Nov 21 2023 at 17:20 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> The default-on trigger has been supported in barebox since commit
> 767c6b4a814a2a000f3b (2014-02-28, Sascha Hauer: "led: Add default-on
> trigger").
>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/leds/common.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.rst b/Documentation/devicetree/bindings/leds/common.rst
> index 09b4e401bc2c..ad94ceb506b1 100644
> --- a/Documentation/devicetree/bindings/leds/common.rst
> +++ b/Documentation/devicetree/bindings/leds/common.rst
> @@ -9,6 +9,7 @@ Common leds properties
>      * ``net`` - LED indicates network activity (tx and rx)
>      * ``net-rx`` - LED indicates network activity (rx only)
>      * ``net-tx`` - LED indicates network activity (tx only)
> +    * ``default-on`` – LED is switched on by default

the lines before utilize the character '-' while in your new line a '–'
is used. I think this should be consistent in one or the other
direction.

Best regards
Ulrich


>  * ``label``: The label for this LED. If omitted, the label is taken
>    from the node name (excluding the unit address).
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] Documentation: dt-bindings: leds: document 'default-on' trigger

[Roland Hieber]

On Wed, Nov 22, 2023 at 06:24:21AM +0100, Ulrich Ölmann wrote:
> Hi Roland,
> 
> On Tue, Nov 21 2023 at 17:20 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> > The default-on trigger has been supported in barebox since commit
> > 767c6b4a814a2a000f3b (2014-02-28, Sascha Hauer: "led: Add default-on
> > trigger").
> >
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/leds/common.rst | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/common.rst b/Documentation/devicetree/bindings/leds/common.rst
> > index 09b4e401bc2c..ad94ceb506b1 100644
> > --- a/Documentation/devicetree/bindings/leds/common.rst
> > +++ b/Documentation/devicetree/bindings/leds/common.rst
> > @@ -9,6 +9,7 @@ Common leds properties
> >      * ``net`` - LED indicates network activity (tx and rx)
> >      * ``net-rx`` - LED indicates network activity (rx only)
> >      * ``net-tx`` - LED indicates network activity (tx only)
> > +    * ``default-on`` – LED is switched on by default
> 
> the lines before utilize the character '-' while in your new line a '–'
> is used. I think this should be consistent in one or the other
> direction.

Huh yes… these two characters you wrote look the same on my terminal,
but they are indeed different when I paste them somewhere else!

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

[PATCH v2] Documentation: dt-bindings: leds: document 'default-on' trigger

[Roland Hieber]

The default-on trigger has been supported in barebox since commit
767c6b4a814a2a000f3b (2014-02-28, Sascha Hauer: "led: Add default-on
trigger").

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
PATCH v2:
 * change U+2013 EN DASH to U+002D HYPHEN-MINUS to be consistent
   with the rest of the list (feedback from Ulrich Ölmann)

PATCH v1: https://lore.barebox.org/barebox/20231121162009.160644-1-rhi@pengutronix.de
---
 Documentation/devicetree/bindings/leds/common.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/common.rst b/Documentation/devicetree/bindings/leds/common.rst
index 09b4e401bc2c..8bf41f0d649b 100644
--- a/Documentation/devicetree/bindings/leds/common.rst
+++ b/Documentation/devicetree/bindings/leds/common.rst
@@ -9,6 +9,7 @@ Common leds properties
     * ``net`` - LED indicates network activity (tx and rx)
     * ``net-rx`` - LED indicates network activity (rx only)
     * ``net-tx`` - LED indicates network activity (tx only)
+    * ``default-on`` - LED is switched on by default
 
 * ``label``: The label for this LED. If omitted, the label is taken
   from the node name (excluding the unit address).
-- 
2.39.2

Re: [PATCH v2] Documentation: dt-bindings: leds: document 'default-on' trigger

[Sascha Hauer]

On Wed, Nov 22, 2023 at 10:51:14AM +0100, Roland Hieber wrote:
> The default-on trigger has been supported in barebox since commit
> 767c6b4a814a2a000f3b (2014-02-28, Sascha Hauer: "led: Add default-on
> trigger").
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> PATCH v2:
>  * change U+2013 EN DASH to U+002D HYPHEN-MINUS to be consistent
>    with the rest of the list (feedback from Ulrich Ölmann)
> 
> PATCH v1: https://lore.barebox.org/barebox/20231121162009.160644-1-rhi@pengutronix.de
> ---
>  Documentation/devicetree/bindings/leds/common.rst | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/Documentation/devicetree/bindings/leds/common.rst b/Documentation/devicetree/bindings/leds/common.rst
> index 09b4e401bc2c..8bf41f0d649b 100644
> --- a/Documentation/devicetree/bindings/leds/common.rst
> +++ b/Documentation/devicetree/bindings/leds/common.rst
> @@ -9,6 +9,7 @@ Common leds properties
>      * ``net`` - LED indicates network activity (tx and rx)
>      * ``net-rx`` - LED indicates network activity (rx only)
>      * ``net-tx`` - LED indicates network activity (tx only)
> +    * ``default-on`` - LED is switched on by default
>  
>  * ``label``: The label for this LED. If omitted, the label is taken
>    from the node name (excluding the unit address).
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |