From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 13 Apr 2026 10:22:20 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCCYm-00Bea5-0l for lore@lore.pengutronix.de; Mon, 13 Apr 2026 10:22:20 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wCCYl-0004Q1-KG for lore@pengutronix.de; Mon, 13 Apr 2026 10:22:20 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RR7c1MJz76Ls76y/dLkm+Sy1ZOrtXpq8UzMRZLh0GEk=; b=gvtbsmmqXL/ZR49WgXSa0cX/G/ dACP0vOuIgNves/eVNAfFPgSslgoRt0Wld6yjfmmxaBtIBemP8qw+Qz0CXKAhes+gGbYLanaQt5NK QmdIFVIqZf747Whsd/UUJa0V7AAZJ6iC/HioE+l14SVM9zxdaNj4RJJ+Vt5vUDlZwowZ7IkD/mjWk BbMFx7v6Wz8Ta8HWUEVwDneyhlZD+qHaKG0O8k9r9gqan/tRaUcBKAPbiXZ9N3O+oikxH+xSz6R0A TMQv10ZBD2Kv2f+Moc82ROgx8sAHlUG8gWaxCl6O5xE527j4LckWtnR4WnxapVSOmjP/C1jYRi6k2 ISlKKEIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCCYQ-0000000FG2e-3YAz; Mon, 13 Apr 2026 08:21:58 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCCYP-0000000FG2C-20mt for barebox@bombadil.infradead.org; Mon, 13 Apr 2026 08:21:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:To:Subject:MIME-Version:Date:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=RR7c1MJz76Ls76y/dLkm+Sy1ZOrtXpq8UzMRZLh0GEk=; b=Xq4IGoWfg/DRvF5gAomtXWJYIO BI6BtxHy/+iRXzjTfXtiaKoCIR3YQ5XxOBMqbDMfCAhfGiSx1nrchTjgLDMeLvynwWmj8f+oEOKCN mEMAGBSdMpTvveOqWZTPGtqnXuzE6vpziJYkGTWdAXH3rbiutXgSWzlPPpETMYz7lHkNppYdf8GcF FUFKwWyWpFe5sqQ9Ty6xSqOsMG2mLB0gsZJ69LM9iAleLNQpfOsSnKpZYOlpTAhkIDFGuiOb3kJuD LnLdHtrzzhl3Tb1j3KrFF0G0NssBC9lA+pJlvJNP4vDgcPK2CwJaryZudnw9cio3PjzjUP7YElaLJ 1CtvPolA==; Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCCYJ-0000000GNpS-3obH for barebox@lists.infradead.org; Mon, 13 Apr 2026 08:21:56 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wCCYI-0004GO-2Q; Mon, 13 Apr 2026 10:21:50 +0200 Message-ID: <70c83fa9-bca5-4ec0-ba56-76589341867a@pengutronix.de> Date: Mon, 13 Apr 2026 10:21:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Fabian Pflug , Sascha Hauer , BAREBOX References: <20260330-v2026-03-0-topic-soc_bin_id-v1-0-11292f75b196@pengutronix.de> <20260330-v2026-03-0-topic-soc_bin_id-v1-1-11292f75b196@pengutronix.de> Content-Language: en-US From: Jonas Rebmann In-Reply-To: <20260330-v2026-03-0-topic-soc_bin_id-v1-1-11292f75b196@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260413_092154_289373_AE174F13 X-CRM114-Status: GOOD ( 21.55 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.5 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 1/2] common: misc: add soc_uid_bin to globalvar X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 2026-03-30 14:24, Fabian Pflug wrote: > uidstr and uidbuf could be the same, but don't have to be. This results > in uncertainty on what exactly is the current UID used for > machine_set_hashable and to compare against with TLV. > > Add an additional global var, that represents a binary representation > of the soc_uid_bin variable. gloval var, that encodes SoC-UID registers in a manner uniform across SoCs/manufacturers. > This can now be used to feed as data for bound-soc-uid into > `bareboxtlv-generator.py` or as the value for > `CONFIG_HABV4_CSF_UNLOCK_UID` > > Signed-off-by: Fabian Pflug > --- > common/misc.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/common/misc.c b/common/misc.c > index ecf9574f7a..f18c8b5825 100644 > --- a/common/misc.c > +++ b/common/misc.c > @@ -268,6 +268,7 @@ const uuid_t *barebox_get_product_uuid(void) > BAREBOX_MAGICVAR(global.product.uuid, "SMBIOS-reported product UUID"); > > static char *soc_uid_str; > +static char *soc_uid_bin_str; > static void *soc_uid; > static size_t soc_uid_len; > > @@ -295,16 +296,19 @@ void barebox_set_soc_uid(const char *uidstr, const void *uidbuf, size_t len) > soc_uid = xmemdup(uidbuf, len); > soc_uid_len = len; > > + soc_uid_bin_str = xzalloc(len * 2 + 1); > + bin2hex(soc_uid_bin_str, uidbuf, len); > + > if (uidstr) { > soc_uid_str = xstrdup(uidstr); > } else { > - soc_uid_str = xzalloc(len * 2 + 1); > - bin2hex(soc_uid_str, uidbuf, len); > + soc_uid_str = soc_uid_bin_str; > } > > machine_id_set_hashable(uidbuf, len); > > globalvar_add_simple_string("soc_uid", &soc_uid_str); > + globalvar_add_simple_string("soc_uid_bin", &soc_uid_bin_str); > } > BAREBOX_MAGICVAR(global.soc_uid, "SoC Unique ID"); soc_uid_bin needs a BAREBOX_MAGICVAR entry too, to show up in https://www.barebox.org/doc/latest/user/variables.html > > -- Pengutronix e.K. | Jonas Rebmann | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |