[PATCH] ARM: Phytec phyCORE i.MX6: delete wrong memory node

[PATCH] ARM: Phytec phyCORE i.MX6: delete wrong memory node

[Sascha Hauer]

The phyCORE i.MX6 has two memory nodes in the device tree. /memory comes
from the barebox dtsi file and contains dummy values. This is
unnecessary, barebox will create a memory node when booting the kernel.
The other one comes from the Kernel dtsi and causes more harm. The
memory in the node has a size of 2GiB. Not all boards have so much
memory, since 8226f7f909 ("of: base: parse all available memory nodes")
this node is no longer ignored and now all boards are assumed to have
2GiB of memory. Remove the node using /delete-node/

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
index 841ad653b2..3cb8b3782a 100644
--- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
@@ -12,10 +12,7 @@
 #include <arm/imx6qdl-phytec-pfla02.dtsi>
 
 / {
-	memory {
-		/* let barebox fill the memory node */
-		reg = <0 0>;
-	};
+	/delete-node/ memory@10000000;
 
 	chosen {
 		environment-nand {
-- 
2.26.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: Phytec phyCORE i.MX6: delete wrong memory node

[Stefan Riedmüller]

Hi Sascha,

On 29.04.20 13:29, Sascha Hauer wrote:
> The phyCORE i.MX6 has two memory nodes in the device tree. /memory comes

Here and in the subject line you mention the phyCORE-i.MX 6 but it is 
actually the phyFLEX which you change.

Besides that,
Reviewed-by: Stefan Riedmueller <s.riedmueller@phytec.de>

> from the barebox dtsi file and contains dummy values. This is
> unnecessary, barebox will create a memory node when booting the kernel.
> The other one comes from the Kernel dtsi and causes more harm. The
> memory in the node has a size of 2GiB. Not all boards have so much
> memory, since 8226f7f909 ("of: base: parse all available memory nodes")
> this node is no longer ignored and now all boards are assumed to have
> 2GiB of memory. Remove the node using /delete-node/
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>   arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> index 841ad653b2..3cb8b3782a 100644
> --- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -12,10 +12,7 @@
>   #include <arm/imx6qdl-phytec-pfla02.dtsi>
>   
>   / {
> -	memory {
> -		/* let barebox fill the memory node */
> -		reg = <0 0>;
> -	};
> +	/delete-node/ memory@10000000;
>   
>   	chosen {
>   		environment-nand {
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: Phytec phyCORE i.MX6: delete wrong memory node

[Sascha Hauer]

Hi Stefan,

On Wed, Apr 29, 2020 at 02:00:55PM +0200, Stefan Riedmüller wrote:
> Hi Sascha,
> 
> On 29.04.20 13:29, Sascha Hauer wrote:
> > The phyCORE i.MX6 has two memory nodes in the device tree. /memory comes
> 
> Here and in the subject line you mention the phyCORE-i.MX 6 but it is
> actually the phyFLEX which you change.

Yes, I mistakenly thought they use the same base device tree. Changed to
phyFLEX.

> 
> Besides that,
> Reviewed-by: Stefan Riedmueller <s.riedmueller@phytec.de>

Thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox