From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 11 Jan 2023 21:14:50 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pFhUp-0098bm-0W for lore@lore.pengutronix.de; Wed, 11 Jan 2023 21:14:50 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFhUm-0007EO-VC for lore@pengutronix.de; Wed, 11 Jan 2023 21:14:49 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h0tLbeQwUaWB/3epnnXwZT0FGLshpvWuM1CQegMVp+w=; b=qy7kDScOIyionjgS+hmXnv0Z7R vgx1o1OpRtZQ036elNooYe6BoxafLBbLJcFQ5ek1bH8WpGZRipyULiYYWviK4bmhMHhjwvrfyK5du 0g/ISwkPZBcwOBMRlq6gZqOfujgXaNtzTHrkRRJH7hh/ZsQQd5TUaS/dyn/+JFQkXXthFgMVotHVj YGoHVnQSuB3NGfnizg/arJHHSestxtVsQrlSvonZgOqI/wm3qN9CIzEcLks9NqhMZOB1twPgqkKjW mZtcLdc2+iH1vf6agrx/w7RiPQ//WzZuw1EGKJFThsgrG7b7H190o1Kgh32jxP9Rs8KlhQmjHVBEM FkSyVBzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFhTU-00Cq0k-Vt; Wed, 11 Jan 2023 20:13:29 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFhTP-00CpzK-74 for barebox@lists.infradead.org; Wed, 11 Jan 2023 20:13:24 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pFhTL-00072P-44; Wed, 11 Jan 2023 21:13:19 +0100 Message-ID: <72d6d708-3fef-83a5-812e-85be67615eda@pengutronix.de> Date: Wed, 11 Jan 2023 21:13:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Lucas Stach , barebox@lists.infradead.org References: <20230111182157.1702865-1-l.stach@pengutronix.de> <20230111182157.1702865-2-l.stach@pengutronix.de> <428fb95a-1d48-734d-a715-8d6cd5bae4bc@pengutronix.de> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_121323_285338_04EEB859 X-CRM114-Status: GOOD ( 24.37 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 2/3] ARM: dts: i.MX8MP: move MAC address description to common location X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 11.01.23 21:00, Lucas Stach wrote: > Hi Ahmad, > > Am Mittwoch, dem 11.01.2023 um 20:03 +0100 schrieb Ahmad Fatoum: >> Hello Lucas, >> >> On 11.01.23 19:21, Lucas Stach wrote: >>> All i.MX8MP boards should consult the common fuse locations for the >>> MAC address of the network interfaces. Also add the second location >>> for the EQOS network interface. >> >> Do we really want to extend use of this binding? The upstream kernel >> DT already has nvmem-cells for the MAC addresses and we have support >> for reading that out. >> > I thought about this too, but... > >> Only thing missing is the equivalent of >> >> Linux commit d0221a780cbc ("nvmem: imx-ocotp: add support for post processing") >> > This isn't the only thing missing. To handle the second MAC address via > NMEM, we would need to add unaligned read/write support to the OCOTP > driver. The currently used regmap_read/write_bulk API does only work > with register aligned accesses. The benefit of NVMEM didn't look that > tempting anymore when looking at the cost of the necessary OCOTP driver > changes, so I choose to go with the more minimal change. You can switch the driver over to use nvmem_regmap_register(), which will take care of the alignment for you. I still think it's worth it. Cheers, Ahmad > > Regards, > Lucas > >> Cheers, >> Ahmad >> >>> >>> Signed-off-by: Lucas Stach >>> --- >>> arch/arm/dts/imx8mp-evk.dts | 4 ---- >>> arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts | 4 ---- >>> arch/arm/dts/imx8mp.dtsi | 1 + >>> 3 files changed, 1 insertion(+), 8 deletions(-) >>> >>> diff --git a/arch/arm/dts/imx8mp-evk.dts b/arch/arm/dts/imx8mp-evk.dts >>> index d992b14882a3..28d8c5f9292e 100644 >>> --- a/arch/arm/dts/imx8mp-evk.dts >>> +++ b/arch/arm/dts/imx8mp-evk.dts >>> @@ -68,7 +68,3 @@ >>> reg = <0xe0000 0x20000>; >>> }; >>> }; >>> - >>> -&ocotp { >>> - barebox,provide-mac-address = <&fec 0x640>; >>> -}; >>> diff --git a/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts >>> index c47e7285a703..6e81f58e2786 100644 >>> --- a/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts >>> +++ b/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts >>> @@ -53,7 +53,3 @@ >>> reg = <0xe0000 0x20000>; >>> }; >>> }; >>> - >>> -&ocotp { >>> - barebox,provide-mac-address = <&fec 0x640>; >>> -}; >>> diff --git a/arch/arm/dts/imx8mp.dtsi b/arch/arm/dts/imx8mp.dtsi >>> index 5da79f13d339..379fa49d6042 100644 >>> --- a/arch/arm/dts/imx8mp.dtsi >>> +++ b/arch/arm/dts/imx8mp.dtsi >>> @@ -13,6 +13,7 @@ >>> feat: &ocotp { >>> #feature-cells = <1>; >>> barebox,feature-controller; >>> + barebox,provide-mac-address = <&fec 0x640 &eqos 0x650>; >>> }; >>> >>> &pgc_mipi_phy1 { >> > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |