Re: [PATCH 4/6] common: boards: qemu: process some standard fw_cfg keys

[Ahmad Fatoum <a.fatoum@barebox.org>]

Hi Sascha,

On 1/19/26 12:13 PM, Sascha Hauer wrote:
> On Thu, Jan 15, 2026 at 01:06:12PM +0100, Ahmad Fatoum wrote:
>> While we have FW_CFG support as file system, there is a number of keys
>> that precede the keys in the file system, which can be useful in some
>> scenarios.
>>
>> Add support for QEMU -uuid, -kernel, -initrd, -append options as well as
>> a /boot/qemu_fw_cfg script that continues booting according to the latter
>> three options.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
>> ---
>>  common/boards/Kconfig                         |   8 +
>>  common/boards/Makefile                        |   1 +
>>  common/boards/qemu/Makefile                   |   4 +
>>  .../defaultenv-qemu_fw_cfg/boot/qemu_fw_cfg   |  12 +
>>  common/boards/qemu/fw_cfg.c                   | 208 ++++++++++++++++++
>>  drivers/firmware/Kconfig                      |   1 +
>>  6 files changed, 234 insertions(+)
>>  create mode 100644 common/boards/qemu/Makefile
>>  create mode 100755 common/boards/qemu/defaultenv-qemu_fw_cfg/boot/qemu_fw_cfg
>>  create mode 100644 common/boards/qemu/fw_cfg.c
>>
>> diff --git a/common/boards/Kconfig b/common/boards/Kconfig
>> index 74947316954b..a9e1b75a7641 100644
>> --- a/common/boards/Kconfig
>> +++ b/common/boards/Kconfig
>> @@ -1,5 +1,13 @@
>>  # SPDX-License-Identifier: GPL-2.0-only
>>  
>> +config BOARD_QEMU
>> +	bool "Extra support for QEMU-emulated boards" if COMPILE_TEST
>> +
>> +config BOARD_QEMU_VIRT
>> +	bool
>> +	select OF_OVERLAY
>> +	select BOARD_QEMU
>> +
>>  config BOARD_QEMU_VIRT
>>  	bool
>>  	select OF_OVERLAY
> 
> You likely intended to just add "select BOARD_QEMU" instead of
> duplicating the option. I'll fix that while applying.

Indeed. Thank you.

Cheers,
Ahmad

> 
> Sascha
>