From: Yann Sionneau <ysionneau@kalrayinc.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] sandbox: add cpuinfo command
Date: Wed, 16 Oct 2024 11:32:40 +0200 [thread overview]
Message-ID: <777ad095-34c5-43fd-bd52-a7ca938adcf6@kalrayinc.com> (raw)
In-Reply-To: <20241016085543.3961965-2-a.fatoum@pengutronix.de>
Hi Ahmad,
On 16/10/2024 10:55, Ahmad Fatoum wrote:
> We have stack dump support in sandbox via AddressSanitizer, if it's
> compiled in. To make it easier to test proper operation, let's a cpuinfo
Small typo in the commit msg
> command like we already do on ARM and give it the same -s option.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>
> +BAREBOX_CMD_START(cpuinfo)
> + .cmd = do_cpuinfo,
> + BAREBOX_CMD_DESC("show info about CPU")
> + BAREBOX_CMD_OPTS("[-s]")
It seems the -s option here is mandatory, maybe remove the [ ] brackets? Not sure if it means "optional" here...
Regards,
--
Yann
next prev parent reply other threads:[~2024-10-16 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 8:55 [PATCH 1/2] sandbox: add --command line support Ahmad Fatoum
2024-10-16 8:55 ` [PATCH 2/2] sandbox: add cpuinfo command Ahmad Fatoum
2024-10-16 9:32 ` Yann Sionneau [this message]
2024-10-18 9:06 ` Sascha Hauer
2024-10-21 7:35 ` Ahmad Fatoum
2024-10-16 9:54 ` [PATCH 1/2] sandbox: add --command line support Yann Sionneau
2024-10-16 9:56 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=777ad095-34c5-43fd-bd52-a7ca938adcf6@kalrayinc.com \
--to=ysionneau@kalrayinc.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox