Re: [PATCH] sandbox: defconfig: activate CONFIG_CONSOLE_ACTIVATE_ALL

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Mohamed,

On 11.10.24 22:18, Mohamed Sawy wrote:
> The default CONSOLE_ACTIVATE value set in common/Kconfig is
> CONSOLE_ACTIVATE_ALL_FALLBACK.
> 
> Which adds an error when there's no explicit activation for a specific
> console, that is important for real hardware as it may write barebox log
> to external devices that don't expect it.
> 
> But in case of sandbox mode there's no explicit activation and the error
> is always there in spite of number of consoles and there are no external
> devices to worry about.
> 
> Fixes: 219b2341dc16 ("console: add new CONSOLE_ACTIVATE_ALL_FALLBACK option")
> Signed-off-by: Mohamed Sawy <mohamedsawy1022@gmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks for the fix,
Ahmad

> ---
>  arch/sandbox/configs/sandbox_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/sandbox/configs/sandbox_defconfig b/arch/sandbox/configs/sandbox_defconfig
> index 1bb98c550c..a5e0f72c63 100644
> --- a/arch/sandbox/configs/sandbox_defconfig
> +++ b/arch/sandbox/configs/sandbox_defconfig
> @@ -3,6 +3,7 @@ CONFIG_HUSH_FANCY_PROMPT=y
>  CONFIG_CMDLINE_EDITING=y
>  CONFIG_AUTO_COMPLETE=y
>  CONFIG_MENU=y
> +CONFIG_CONSOLE_ACTIVATE_ALL=y
>  CONFIG_CONSOLE_ALLOW_COLOR=y
>  CONFIG_PARTITION_DISK_EFI=y
>  CONFIG_DEFAULT_COMPRESSION_GZIP=y


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |