Re: [PATCH] serial: omap: make Linux console name configurable

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 3/19/25 12:16, Sascha Hauer wrote:
> On Wed, Mar 19, 2025 at 12:03:31PM +0100, Ahmad Fatoum wrote:
>>
>>
>> On 3/19/25 12:01, Sascha Hauer wrote:
>>> On Wed, Mar 19, 2025 at 11:55:53AM +0100, Ahmad Fatoum wrote:
>>>> Hello Sascha,
>>>>
>>>> On 3/19/25 11:22, Sascha Hauer wrote:
>>>>> Depending on the configuration Linux on OMAP SoCs either needs ttyO or
>>>>> ttyS as console name. We used to pass ttyO, but c1c0d18973
>>>>> ("serial: omap: Use ttyS as Linux console name") recently changed this
>>>>> to ttyS which breaks setups that used to work earlier. Make the
>>>>> name configurable to allow for setups requiring ttyS and use ttyO
>>>>> as default to keep existing setups working.
>>>>>
>>>>> Note that with ti,am4372-uart we used to pass ttyO as well, but this
>>>>> specific compatible is only supported by the 8250 based driver which
>>>>> needs ttyS as console name. 
>>>>
>>>> This reads as if 8250_omap supports only ttyS, but it has logic to
>>>> support ttyO as well.
>>>
>>> s/needs/prefers/ maybe
>>
>> Ye, further below there is also 'will also have no effect', which is not
>> true as it hides an ugly error message.
>>
>> Can you reword these two parts and make the option default ARCH_K3?
> 
> ARCH_K3 doesn't need this option.

Ah, ok. Then feel free to add my:

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Cheers,
Ahmad

> 
> Sascha
>