From: Robin van der Gracht <robin@protonic.nl>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox <barebox@lists.infradead.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: Re: Boot hangs during sdhci_transfer_data_dma
Date: Tue, 21 Jun 2022 12:07:50 +0200 [thread overview]
Message-ID: <7fb5b14b9de44e2e464144defdc33672@protonic.nl> (raw)
In-Reply-To: <20220621074645.GS1615@pengutronix.de>
On 2022-06-21 09:46, Sascha Hauer wrote:
> Hi Robin,
...
> We should only ever
> clear the bits we have handled, like sdhci_transfer_data_dma() does with
>
> sdhci_write32(sdhci, SDHCI_INT_STATUS, SDHCI_INT_DMA);
I just noticed that the tegra-sdmmc mci driver might have the same issue.
https://git.pengutronix.de/cgit/barebox/tree/drivers/mci/tegra-sdmmc.c#n149
It can prevent the following conditional from ever evaluating true trapping
the process in the while loop.
https://git.pengutronix.de/cgit/barebox/tree/drivers/mci/tegra-sdmmc.c#n203
This driver clears the status register on error (not on start/end of
function)
with an old value 'val' which can be lacking status bits that popped up
along the way...
I can't test code changes for this platform.
- Robin
prev parent reply other threads:[~2022-06-21 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 14:33 Robin van der Gracht
2022-06-21 7:46 ` Sascha Hauer
2022-06-21 9:32 ` Robin van der Gracht
2022-06-21 10:07 ` Robin van der Gracht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fb5b14b9de44e2e464144defdc33672@protonic.nl \
--to=robin@protonic.nl \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--subject='Re: Boot hangs during sdhci_transfer_data_dma' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox