From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 17 Aug 2022 08:31:57 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oOCar-001bbn-UT for lore@lore.pengutronix.de; Wed, 17 Aug 2022 08:31:57 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOCap-00023F-Vg for lore@pengutronix.de; Wed, 17 Aug 2022 08:31:56 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7dy7dZaQdv1/rVqUz4ZpwPjBvMODesFoLiyJ++MmK6I=; b=hcGwAqY5iioWINuowaGoNt8sBZ rkwER0mwcOleOYqJfokcpknWJgDQzsgtReNb2WzHz58PZcmmBI/zASkWt8Pk++H+P1rvPE6kHrjMR YcmSiywYDjDqRL13xvyo2IotkJ8CQjLFMZGFcjH3uUEfMRvC537bV1hzNJelt+/p5/M/nW/YclmU+ Wd2oO4K1myyFlZScXaf4I7o81fFZMVLnbRh4UlVLtnCahJJflbPnt7hf0GPbTZSdw0O1PWCaaWZul sPWPlvJo1N64NZytiFVadH72QFsbFYU2H8p0kFQ50mQa7epl7do1uxSkhig23GC2AugfIVPGmEYKe 0i9/AnyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOCZF-00ByiR-Fw; Wed, 17 Aug 2022 06:30:17 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOCZA-00BygA-AH for barebox@lists.infradead.org; Wed, 17 Aug 2022 06:30:13 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oOCZ8-0001dq-0w; Wed, 17 Aug 2022 08:30:10 +0200 Message-ID: <80d3e34a-37aa-1d04-ff21-5ccd7a9cadc4@pengutronix.de> Date: Wed, 17 Aug 2022 08:30:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Sascha Hauer Cc: barebox@lists.infradead.org, mfe@pengutronix.de References: <20220815091733.1973736-1-a.fatoum@pengutronix.de> <20220816075710.GG17485@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20220816075710.GG17485@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_233012_420714_8319BBC8 X-CRM114-Status: GOOD ( 14.91 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] usbgadget: autostart: add usbgadget_autostart helper for board code X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hello Sascha, On 16.08.22 09:57, Sascha Hauer wrote: > The code is a bit hard to follow with the approach of starting the > gadget exclusively from the setter function of global.usbgadget.autostart > > Can we go with the following approach? It moves the starting of the usb > gadget to a function that first checks if all prerequisites are > fulfilled to start the gadget and then starts it if desired. Just tested it and works for me. Please apply. Thanks! Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |