Re: [PATCH RFT] blspec: support boot /dev/disk0.rootfs to mean boot disk0.rootfs

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 19.06.23 17:08, Marco Felsch wrote:
> Hi Ahmad,
> 
> On 23-06-19, Ahmad Fatoum wrote:
>> boot /dev/disk0.rootfs would always fail:
>>
>>   Nothing bootable found on '/dev/disk0.rootfs'
>>   Nothing bootable found
>>
>> boot /mnt/disk0.rootfs and boot disk0.rootfs would however work.
>> This can be surprising to users, so just skip over /dev if supplied.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>> I am not sure why this wasn't the case before. Any ambiguity in doing it
>> this way? Change still needs to be tested.
> 
> According commands/boot.c help message:
> 
> | "BOOTSRC can be:"
> | "- a filename under /env/boot/"
> | "- a full path to a boot script"
> | "- a full path to a bootspec entry"
> | "- a device name"
> | "- a partition name under /dev/"
> | "- a full path to a directory which"
> | "   - contains boot scripts, or"
> | "   - contains a loader/entries/ directory containing bootspec entries"
> 
> the 'full path' to a device is not suported yet. Should that be fixed
> within the boot-cmd?

You can interpret "a partition name under /dev/" as meaning both
partition name without /dev/ or with /dev/ IMO.

> 
> Regards,
>   Marco
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |