From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 30 Jul 2024 10:36:07 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sYiL1-004PHP-2d for lore@lore.pengutronix.de; Tue, 30 Jul 2024 10:36:07 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYiL0-0007PR-RB for lore@pengutronix.de; Tue, 30 Jul 2024 10:36:07 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4FrAqvcqQRCaQHzsLcd2RFOxEVza72R9rq6whTLYH3g=; b=OUioW0rIeo37vcVkEjhsMggTZn 93v0RafaMPxXDKNqg0lVQYLV5CHXrRv2cPeX65cYT9cBx6WpR/0zrPA6QYPoJasCwa3dDMbF2ZTlr o/40Styi8KesLPfiSpocKPOuH+sPP+/mxzU+3huWU739kifh1ftp54/ND1aCnVpxNDw6SShuazr2d ddy35oA+PhMr1+sgWVHDeHfzTLyElXaaujUMB5wRqfOmLiY+RPzE8kLzT6AaRtKWdjAqV/kV3+3Q/ ymYAWOMEtofmVyEQHSeQeOyPwv5nuZglF7Wmhpjt1K+LpsZIMAzvPYzrDDlz1FCBv83d3FfC3+DBl lusY6W/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYiKX-0000000EJ4K-1Y7k; Tue, 30 Jul 2024 08:35:37 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYiIO-0000000EI9w-0lTk for barebox@lists.infradead.org; Tue, 30 Jul 2024 08:33:25 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sYiIM-00073Z-UD; Tue, 30 Jul 2024 10:33:22 +0200 Message-ID: <82cad5a3-4218-4c08-a419-2f492bf3734b@pengutronix.de> Date: Tue, 30 Jul 2024 10:33:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer Cc: barebox@lists.infradead.org References: <20240726122623.3566935-1-a.fatoum@pengutronix.de> Content-Language: en-US, de-DE, de-BE From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_013324_275460_AE8EAAC1 X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [RESEND][PATCH 1/2] console: add new CONSOLE_ACTIVATE_ALL_FALLBACK option X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 7/30/24 10:09, Sascha Hauer wrote: > On Fri, Jul 26, 2024 at 02:26:22PM +0200, Ahmad Fatoum wrote: >> We already have three CONSOLE_ACTIVATE options and every one of them has >> drawbacks: >> >> - ACTIVATE_ALL: May write barebox log to external devices like MCUs >> that don't expect it >> >> - ACTIVATE_FIRST: Not applicable for most systems that probe from >> device tree, where the order of probe is not necessarily fixed, >> so what console is first may change over updates >> >> - ACTIVATE_NONE: has a misleading name and may leave the user without >> any consoles at all if nothing else activates a console >> >> Let's add a new option and make it the default, which avoids all these >> issues: Like ACTIVATE_NONE, it expects board code, DT or environment to >> enable a console and if none of them do it falls back to activating all >> consoles, so the user isn't kept in the dark with an error instructing >> the user to fix this. >> >> Signed-off-by: Ahmad Fatoum >> --- >> Sent out second patch only by mistake instead of both... >> --- >> common/Kconfig | 19 ++++++++++++++++++- >> common/console.c | 27 +++++++++++++++++++++++++++ >> 2 files changed, 45 insertions(+), 1 deletion(-) >> >> diff --git a/common/Kconfig b/common/Kconfig >> index 31360892aeef..2dda5ce5743a 100644 >> --- a/common/Kconfig >> +++ b/common/Kconfig >> @@ -812,7 +812,7 @@ endchoice >> choice >> prompt "Console activation strategy" >> depends on CONSOLE_FULL >> - default CONSOLE_ACTIVATE_FIRST >> + default CONSOLE_ACTIVATE_ALL_FALLBACK >> >> config CONSOLE_ACTIVATE_FIRST >> bool >> @@ -831,6 +831,23 @@ config CONSOLE_ACTIVATE_ALL >> Only the first registered console will have the full startup >> log though. >> >> +config CONSOLE_ACTIVATE_ALL_FALLBACK >> + bool >> + prompt "activate all consoles as fallback" >> + help >> + This option is similar to CONFIG_CONSOLE_ACTIVATE_NONE in that it >> + leaves consoles disabled on startup. If by the end of barebox >> + startup, no consoles have been activated via board code, device >> + tree or environment, barebox will enable all registered consoles >> + as fallback, so the user has a chance to see output. >> + >> + This will be indicated by a fat error, so the user knows that >> + the configuration needs to be fixed. If you don't see any >> + output at all, consider trying again after enabling >> + CONFIG_CONSOLE_ACTIVATE_ALL, so consoles are activated immediately >> + at registration time and/or with CONFIG_DEBUG_LL, so barebox output >> + is written even before console drivers were registered. >> + >> config CONSOLE_ACTIVATE_NONE >> prompt "leave all consoles disabled" >> bool >> diff --git a/common/console.c b/common/console.c >> index 73b4c4d4db01..e83a3e1e2d7f 100644 >> --- a/common/console.c >> +++ b/common/console.c >> @@ -450,6 +450,33 @@ int console_unregister(struct console_device *cdev) >> } >> EXPORT_SYMBOL(console_unregister); >> >> +static int console_activate_all_fallback(void) >> +{ >> + int activate = CONSOLE_STDIOE; >> + struct console_device *cdev; >> + >> + for_each_console(cdev) { >> + if (cdev->f_active & (CONSOLE_STDOUT | CONSOLE_STDERR)) >> + return 0; >> + } >> + >> + if (IS_ENABLED(CONFIG_CONSOLE_DISABLE_INPUT)) >> + activate &= ~CONSOLE_STDIN; >> + >> + for_each_console(cdev) >> + console_set_active(cdev, activate); >> + >> + /* >> + * This is last resort, so the user is not kept in the dark. >> + * Writing to all consoles is a bad idea as the devices at the >> + * other side might get confused by it, thus the error log level. >> + */ >> + pr_err("No consoles were activated. Activating all consoles as fallback!\n"); >> + >> + return 0; >> +} >> +postenvironment_initcall(console_activate_all_fallback); > > Shouldn't this code only run when CONSOLE_ACTIVATE_ALL_FALLBACK is > enabled? Of course, sorry about that. Just sent out v3. > > Sascha >