From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 26 May 2021 13:49:34 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lls2Y-0007bJ-2M for lore@lore.pengutronix.de; Wed, 26 May 2021 13:49:34 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lls2T-0002nQ-Mg for lore@pengutronix.de; Wed, 26 May 2021 13:49:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=qXGZGp2oP41QcCzlayOz6z619Ltx1S9dHkJH7lEoMZY=; b=osHOFXPSqk0lUN1mdScN42oldB MFlvDsPyjou7IJbMF8SQsUL9Pu1iFOjzSuVN2OoejugxmvYZ8yZn/epAzBHQ8Ai3oGv8lxQekRiPS VeG6wvDDwLAoFyI91qprm3jlSMXlZCm/YbwGFJcncZWbH8jwO1u8xFstxELVEaeZFgtpuXGjeIrfC pbqx+51Vd4Xoo7ieZGzrxg7eNVSKEBTCeIybZ1DuF+VOg9PcttO2CWwnh+E/+qBdkikd5hmEnJlc7 TnlGcwM+ehKTMG2NHk2LBdld/Hpv+RsLnevj6uw60LiD34KvJtisApu8nYfzOwnzdKJ7DPBHKOiuB /CVXJkYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lls13-00DgKu-8P; Wed, 26 May 2021 11:48:02 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llq2n-00CxdQ-Kk for barebox@lists.infradead.org; Wed, 26 May 2021 09:41:43 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1llq2m-0004Rr-Bl; Wed, 26 May 2021 11:41:40 +0200 To: Lucas Stach , barebox@lists.infradead.org References: <20210525183733.3345497-1-l.stach@pengutronix.de> <20210525183733.3345497-2-l.stach@pengutronix.de> <4037510acbba84d59bdacfd787ac598a075b03a9.camel@pengutronix.de> From: Ahmad Fatoum Message-ID: <8389275f-beb6-2b85-d031-3407b571109c@pengutronix.de> Date: Wed, 26 May 2021 11:41:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <4037510acbba84d59bdacfd787ac598a075b03a9.camel@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_024141_758526_D0459A55 X-CRM114-Status: GOOD ( 23.74 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 2/2] bootm: add support for booting compressed images X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 26.05.21 11:39, Lucas Stach wrote: > Hi Ahmad, > > Am Mittwoch, dem 26.05.2021 um 11:17 +0200 schrieb Ahmad Fatoum: >> Hello Lucas, >> >> On 25.05.21 20:37, Lucas Stach wrote: >>> ARM64 does not have a self extracting image format, but relies on the image >>> being externally compressed with one of the standard compression algorithms. >>> >>> Add support for decompressing the bootm OS image. It is added in common >>> code as it may also be useful for other images/architectures. >>> >>> Signed-off-by: Lucas Stach >>> --- >>> common/bootm.c | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 92 insertions(+) >>> >>> diff --git a/common/bootm.c b/common/bootm.c >>> index 092116beb94a..2bfb5cb01593 100644 >>> --- a/common/bootm.c >>> +++ b/common/bootm.c >>> @@ -12,6 +12,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> static LIST_HEAD(handler_list); >>> >>> @@ -808,6 +809,85 @@ err_out: >>> return ret; >>> } >>> >>> +static int do_bootm_compressed(struct image_data *img_data) >>> +{ >>> + struct bootm_data bootm_data = { >>> + .oftree_file = img_data->oftree_file, >>> + .initrd_file = img_data->initrd_file, >>> + .tee_file = img_data->tee_file, >>> + .verbose = img_data->verbose, >>> + .verify = img_data->verify, >>> + .force = img_data->force, >>> + .dryrun = img_data->dryrun, >>> + .initrd_address = img_data->initrd_address, >>> + .os_address = img_data->os_address, >> >> I am wondering whether it makes sense to directly extract >> to os_address to avoid the extra copy. Depending on the subsequent >> bootm handler, the image may still need to be relocated, but if >> we choose a generous alignment here, the copy later on could >> be avoided. > > For the common case where we let Barebox/the bootm image handler decide > where to put the OS image, we don't know this address yet when > decompressing the image here. I don't think it makes sense to optimize > the special case where the OS address is already known. I see. A debug print for higher verbosity levels, just before invoking bootm_boot would be nice, so it's easy to find out how long the extraction took. Cheers, Ahmad > > Regards, > Lucas > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox