From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] mtd: nand: add mrvl-nand driver
Date: Thu, 08 Jan 2015 19:56:57 +0100 [thread overview]
Message-ID: <87387l3xty.fsf@free.fr> (raw)
In-Reply-To: <20150108133933.GC23940@pengutronix.de> (Sascha Hauer's message of "Thu, 8 Jan 2015 14:39:33 +0100")
Sascha Hauer <s.hauer@pengutronix.de> writes:
>
> So when use_default is true you use the last entry in the array. This
> means you could skip reading the nand id when use_default is true. This
> is a bit more efficient and makes the intention of the code more clear.
Absolutely agreed, vor v3.
>> + if (chip->options & NAND_BUSWIDTH_16)
>> + ndcr |= NDCR_DWIDTH_M | NDCR_DWIDTH_C;
>> + else
>> + ndcr &= ~NDCR_DWIDTH_M & NDCR_DWIDTH_C;
>
> You want to clear both bits here, right? Then this is wrong and
> should be ndcr &= ~NDCR_DWIDTH_M & ~NDCR_DWIDTH_C;
> (or ndcr &= ~(NDCR_DWIDTH_M | NDCR_DWIDTH_C); which I'd consider more
> readable)
Good catch, I'll take your syntax also. As you probably have guessed, my testing
is with a 16 bits wide NAND.
> Otherwise I'm fine with this driver and we can merge it once the pxa3xx
> base support is ready.
Okay, great. I'm working on it. I'll post the v3 to not forget, and then let's
wait until I have pxa3xx support sorted out. I'll repost anyway the driver once
pxa3xx support is ironed out. In the meantime other reviewers could spot
something I overlooked.
Cheers.
--
Robert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-01-08 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 19:22 Robert Jarzmik
2015-01-08 13:39 ` Sascha Hauer
2015-01-08 18:56 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87387l3xty.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox