From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 9/9] arm/mach-pxa: add mioa701 board
Date: Thu, 24 Nov 2011 22:15:46 +0100 [thread overview]
Message-ID: <874nxtxlvh.fsf@free.fr> (raw)
In-Reply-To: <4ECE0ACE.2070103@pengutronix.de> (Marc Kleine-Budde's message of "Thu, 24 Nov 2011 10:13:50 +0100")
Marc Kleine-Budde <mkl@pengutronix.de> writes:
> On 11/24/2011 04:02 AM, Robert Jarzmik wrote:
>> Add Mitac MioA701 board initial support.
>> The support only provides basic boot and a console over USB
>> (serial gadget).
>
> Please remove the address of the FSF in the header of the files, please
> fix you (C), we don't have 2012 yet :)
OK :)
>> diff --git a/Makefile b/Makefile
>> index 1d1e50d..7e94d37 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -163,8 +163,8 @@ export srctree objtree VPATH
>> # Alternatively CROSS_COMPILE can be set in the environment.
>> # Default value for CROSS_COMPILE is not to prefix executables
>>
>> -ARCH ?= sandbox
>> -CROSS_COMPILE ?=
>> +ARCH ?= arm
>> +CROSS_COMPILE ?= /home/rj/mio_linux/arm-2007q1/bin/arm-none-eabi-
>
> Please remove that hunk :)
Urgh, the little sneaky one.
...zip...
All following remarks will be taken into account for v2.
Thanks for the review.
--
Robert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-11-24 21:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 3:02 [PATCH 0/9] Initial PXA support and Mitac MIOA701 board Robert Jarzmik
2011-11-24 3:02 ` [PATCH 1/9] initial Intel/Marvell PXA support Robert Jarzmik
2011-11-24 9:29 ` Sascha Hauer
2011-11-25 21:26 ` Robert Jarzmik
2011-11-24 3:02 ` [PATCH 2/9] fix association of cache handling code for PXA Robert Jarzmik
2011-11-24 3:02 ` [PATCH 3/9] fix core version selection Robert Jarzmik
2011-11-24 3:02 ` [PATCH 4/9] add PXA framebuffer support Robert Jarzmik
2011-11-24 3:02 ` [PATCH 5/9] drivers: pxafb: Fix IOMEM API evolution Robert Jarzmik
2011-11-24 3:02 ` [PATCH 6/9] drivers: pxafb: add include ifdefery Robert Jarzmik
2011-11-24 3:02 ` [PATCH 7/9] arm/mach-pxa: add gpio direction functions Robert Jarzmik
2011-11-24 3:02 ` [PATCH 8/9] arm/mach-pxa: add basic devices hooks Robert Jarzmik
2011-11-24 3:02 ` [PATCH 9/9] arm/mach-pxa: add mioa701 board Robert Jarzmik
2011-11-24 9:13 ` Marc Kleine-Budde
2011-11-24 21:15 ` Robert Jarzmik [this message]
2011-11-24 9:45 ` Sascha Hauer
2011-11-24 21:22 ` Robert Jarzmik
2011-11-24 23:08 ` Sascha Hauer
2011-11-25 21:50 ` Robert Jarzmik
2011-11-24 9:10 ` [PATCH 0/9] Initial PXA support and Mitac MIOA701 board Marc Kleine-Budde
2011-11-24 9:28 ` Sascha Hauer
2011-11-24 21:32 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nxtxlvh.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox