mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/4] barebox remote control
Date: Fri, 12 Jun 2015 12:36:48 +0200	[thread overview]
Message-ID: <87fv5xi56n.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1434005650-28131-3-git-send-email-s.hauer@pengutronix.de> (Sascha Hauer's message of "Thu, 11 Jun 2015 08:54:08 +0200")

>>>>> "Sascha" == Sascha Hauer <s.hauer@pengutronix.de> writes:

Hi,

 > This adds the ability to control barebox over serial lines. The regular
 > console is designed for human input and is unsuitable for controlling
 > barebox from scripts since characters can be lost on both ends, the data
 > stream contains escape sequences and the prompt cannot be easily matched
 > upon.
 > This approach is based on the RATP protocol. RATP packages start with a
 > binary 0x01 which does not occur in normal console data. Whenever a
 > 0x01 character is detected in the console barebox goes into RATP mode.
 > The RATP packets contain a simple structure with a command/respone
 > type and data for that type. Currently defined types are:


> +int barebox_ratp(struct console_device *cdev)
 > +{
 > +	void *buf = xmalloc(512);
 > +	int ret;
 > +	size_t len;
 > +	struct ratp_ctx *ctx;
 > +	struct ratp *ratp;
 > +
 > +	ctx = xzalloc(sizeof(*ctx));
 > +	ratp = &ctx->ratp;
 > +
 > +	ratp->send = ratp_send;
 > +	ratp->recv = ratp_recv;
 > +	ctx->cdev = cdev;
 > +
 > +	ret = ratp_establish(ratp, false, 0);
 > +	if (ret < 0)
 > +		return ret;
 > +
 > +	ret = ratp_console_register(ctx);
 > +	if (ret)
 > +		return ret;

You're leaking ctx and buf here (and buf below as well).

 > +
 > +	while (1) {
 > +		ret = ratp_poll(ratp);
 > +		if (ret == -EINTR)
 > +			goto out;
 > +		if (ratp_closed(ratp))
 > +			goto out;
 > +
 > +		len = 512;
 > +		ret = ratp_recv_data(ratp, buf, &len);
 > +		if (ret == -EAGAIN)
 > +			continue;
 > +
 > +		if (ret < 0)
 > +			goto out;
 > +
 > +		ret = ratp_bb_dispatch(ctx, buf, len);
 > +		if (ret)
 > +			break;
 > +	}
 > +out:
 > +
 > +	console_unregister(&ctx->ratp_console);
 > +
 > +	free(ctx);
 > +
 > +	return ret;
 > +}


> +++ b/crypto/Kconfig
 > @@ -2,6 +2,7 @@ config CRC32
 >  	bool
 
 >  config CRC16
 > +	default y

Why?

-- 
Bye, Peter Korsgaard

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-06-12 10:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11  6:54 Add " Sascha Hauer
2015-06-11  6:54 ` [PATCH 1/4] Add Reliable Asynchronous Transfer Protocol Sascha Hauer
2015-06-12 12:05   ` Peter Korsgaard
2015-06-15  5:12     ` Sascha Hauer
2015-06-15  7:19       ` Peter Korsgaard
2015-06-17  5:45         ` Sascha Hauer
2015-06-11  6:54 ` [PATCH 2/4] barebox remote control Sascha Hauer
2015-06-12 10:36   ` Peter Korsgaard [this message]
2015-06-15  4:51     ` Sascha Hauer
2015-06-11  6:54 ` [PATCH 3/4] include pyserial trunk Sascha Hauer
2015-06-11 15:48   ` Uwe Kleine-König
2015-06-11  6:54 ` [PATCH 4/4] host side for barebox remote control Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fv5xi56n.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox