From: Peter Korsgaard <peter@korsgaard.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/4] Add Reliable Asynchronous Transfer Protocol
Date: Mon, 15 Jun 2015 09:19:08 +0200 [thread overview]
Message-ID: <87h9q9mob7.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20150615051202.GJ6325@pengutronix.de> (Sascha Hauer's message of "Mon, 15 Jun 2015 07:12:02 +0200")
>>>>> "Sascha" == Sascha Hauer <s.hauer@pengutronix.de> writes:
Hi,
>> > + crc_expect = cyg_crc16(data, len);
>>
>> Why crc16? RFC916 states that the checksum is the inverted 1s complement
>> 16bit sum, E.G. like TCP/UDP/IP header checksums:
> Indeed CRC16 is not correct here according to RFC916. We can implement
> the original checksum algorithm, I'm not sure if that's a good idea
> though. Plain checksumming does not detect lost 0 characters.
True, but missing/extra 0 characters would normally get caught by the
length mismatch, so I'm not sure it is a real problem.
--
Venlig hilsen,
Peter Korsgaard
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-06-15 7:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 6:54 Add barebox remote control Sascha Hauer
2015-06-11 6:54 ` [PATCH 1/4] Add Reliable Asynchronous Transfer Protocol Sascha Hauer
2015-06-12 12:05 ` Peter Korsgaard
2015-06-15 5:12 ` Sascha Hauer
2015-06-15 7:19 ` Peter Korsgaard [this message]
2015-06-17 5:45 ` Sascha Hauer
2015-06-11 6:54 ` [PATCH 2/4] barebox remote control Sascha Hauer
2015-06-12 10:36 ` Peter Korsgaard
2015-06-15 4:51 ` Sascha Hauer
2015-06-11 6:54 ` [PATCH 3/4] include pyserial trunk Sascha Hauer
2015-06-11 15:48 ` Uwe Kleine-König
2015-06-11 6:54 ` [PATCH 4/4] host side for barebox remote control Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9q9mob7.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox