mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Andrei Yakimov <ayakimov@iptec-inc.com>
Cc: barebox@lists.infradead.org
Subject: Re: drivers/mtd/nand/nand_mrvl_nfc.c
Date: Wed, 20 May 2015 20:37:02 +0200	[thread overview]
Message-ID: <87twv7hz8x.fsf@belgarion.home> (raw)
In-Reply-To: <20150520061901.GK6325@pengutronix.de> (Sascha Hauer's message of "Wed, 20 May 2015 08:19:01 +0200")

Sascha Hauer <s.hauer@pengutronix.de> writes:

> Hi Andrei,
>
> +Cc Robert Jarzmik <robert.jarzmik@free.fr>
>
> On Tue, May 19, 2015 at 12:23:22PM -0700, Andrei Yakimov wrote:
>> Please,
>>  change 
>>   case NAND_CMD_PARAM:
>>         host->buf_count = 256;
>> To:
>>   host->buf_count = 768;
>> 
>> If first copy of parameter page corrupted you will not able
>> to use ONFI flash.
>
> Thanks for noting. However, like many other opensource projects we
> communicate changes and change requests with formalized patches. Please
> generate one using git format-patch or similar and send it to the list.
> I'll happily make that change then.

Same from me, I'll happily review a patch.
May I add also that host->ndcb3 and host->data_size deserve the same change
within the NAND_CMD_PARAM case statement.

Cheers.

-- 
Robert

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-05-20 18:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 19:23 drivers/mtd/nand/nand_mrvl_nfc.c Andrei Yakimov
2015-05-20  6:19 ` drivers/mtd/nand/nand_mrvl_nfc.c Sascha Hauer
2015-05-20 18:37   ` Robert Jarzmik [this message]
2015-05-21  0:30     ` drivers/mtd/nand/nand_mrvl_nfc.c Andrei Yakimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twv7hz8x.fsf@belgarion.home \
    --to=robert.jarzmik@free.fr \
    --cc=ayakimov@iptec-inc.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox