mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/7] ARM i.MX51: Add support for the Efika MX Smartbook
Date: Mon, 17 Dec 2012 12:15:06 +0100	[thread overview]
Message-ID: <87txrl7ww5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1355435350-20348-6-git-send-email-s.hauer@pengutronix.de> (Sascha Hauer's message of "Thu, 13 Dec 2012 22:49:08 +0100")

>>>>> "Sascha" == Sascha Hauer <s.hauer@pengutronix.de> writes:

Hi,

 Sascha> +
 Sascha> +	/* USB HOST2 */
 Sascha> +	MX51_PAD_EIM_D27__GPIO2_9,
 Sascha> +	MX51_PAD_GPIO1_5__GPIO1_5,
 Sascha> +	MX51_PAD_EIM_D16__USBH2_DATA0,
 Sascha> +	MX51_PAD_EIM_D17__USBH2_DATA1,
 Sascha> +	MX51_PAD_EIM_D18__USBH2_DATA2,
 Sascha> +	MX51_PAD_EIM_D19__USBH2_DATA3,
 Sascha> +	MX51_PAD_EIM_D20__USBH2_DATA4,
 Sascha> +	MX51_PAD_EIM_D21__USBH2_DATA5,
 Sascha> +	MX51_PAD_EIM_D22__USBH2_DATA6,
 Sascha> +	MX51_PAD_EIM_D23__USBH2_DATA7,
 Sascha> +	MX51_PAD_EIM_A24__USBH2_CLK,
 Sascha> +	MX51_PAD_EIM_A25__USBH2_DIR,
 Sascha> +	MX51_PAD_EIM_A26__GPIO2_20,
 Sascha> +	MX51_PAD_EIM_A27__USBH2_NXT,
 Sascha> +
 Sascha> +	/* USB HOST1 */
 Sascha> +        MX51_PAD_USBH1_CLK__USBH1_CLK,
 Sascha> +        MX51_PAD_USBH1_DIR__USBH1_DIR,
 Sascha> +        MX51_PAD_USBH1_NXT__USBH1_NXT,
 Sascha> +        MX51_PAD_USBH1_DATA0__USBH1_DATA0,
 Sascha> +        MX51_PAD_USBH1_DATA1__USBH1_DATA1,
 Sascha> +        MX51_PAD_USBH1_DATA2__USBH1_DATA2,
 Sascha> +        MX51_PAD_USBH1_DATA3__USBH1_DATA3,
 Sascha> +        MX51_PAD_USBH1_DATA4__USBH1_DATA4,
 Sascha> +        MX51_PAD_USBH1_DATA5__USBH1_DATA5,
 Sascha> +        MX51_PAD_USBH1_DATA6__USBH1_DATA6,
 Sascha> +        MX51_PAD_USBH1_DATA7__USBH1_DATA7,
 Sascha> +	MX51_PAD_USBH1_STP__GPIO1_27,
 Sascha> +	MX51_PAD_EIM_A16__GPIO2_10,

Tab/spaces mixup.

Any specific reason to list USB2 before USB1?


 Sascha> +	/* USB U-Boot */
 Sascha> +	MX51_PAD_EIM_A22__GPIO2_16, /* WLAN enable (1 = on) */
 Sascha> +	MX51_PAD_EIM_A17__GPIO2_11,

That USB U-Boot comment is a bit odd.

 Sascha> +/*
 Sascha> + * Generally this should work on the Efika MX smarttop aswell,
 Sascha> + * but I do not have the hardware to test it, so hardcode this
 Sascha> + * for the smartbook for now.
 Sascha> + */

I have both a smarttop and smartbook, so I'll try to find some time to
test.

 Sascha> +
 Sascha> +	/* Raise the core frequency to 800MHz */
 Sascha> +	console_flush();	

Trailing spaces.


 Sascha> +++ b/arch/arm/boards/efika-mx-smartbook/config.h
 Sascha> @@ -0,0 +1,24 @@
 Sascha> +/**
 Sascha> + * @file
 Sascha> + * @brief Global defintions for the ARM i.MX51 based babbage board

Should probably say efikamx smartbook instead. s/defintions/definitions/

-- 
Bye, Peter Korsgaard

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-12-17 11:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13 21:49 [PATCH] Efika MX Smartbook support Sascha Hauer
2012-12-13 21:49 ` [PATCH 1/7] ata sff: set device pointer in ata port Sascha Hauer
2012-12-13 21:49 ` [PATCH 2/7] mci: Allow to specify device name Sascha Hauer
2012-12-13 21:49 ` [PATCH 3/7] mci i.MX esdhc: Allow to specify devicename from platformdata Sascha Hauer
2012-12-13 21:49 ` [PATCH 4/7] mfd mc13893: Add register defines Sascha Hauer
2012-12-13 21:49 ` [PATCH 5/7] ARM i.MX51: Add support for the Efika MX Smartbook Sascha Hauer
2012-12-15  9:00   ` Sascha Hauer
2012-12-17 11:15   ` Peter Korsgaard [this message]
2012-12-19 20:26     ` Sascha Hauer
2012-12-13 21:49 ` [PATCH 6/7] ARM: Add defconfig for Efika MX smartbook Sascha Hauer
2012-12-13 21:49 ` [PATCH 7/7] USB ehci: Add powerup fixup for EfikaSB Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txrl7ww5.fsf@dell.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox