mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: pxa: add pxa3xx architecture
Date: Mon, 05 Jan 2015 21:35:55 +0100	[thread overview]
Message-ID: <87zj9x3qz8.fsf@free.fr> (raw)
In-Reply-To: <20150105131245.GG4544@pengutronix.de> (Sascha Hauer's message of "Mon, 5 Jan 2015 14:12:45 +0100")

Sascha Hauer <s.hauer@pengutronix.de> writes:

> On Sun, Jan 04, 2015 at 10:41:05AM +0100, Robert Jarzmik wrote:
>> +#ifdef CONFIG_ARCH_PXA2XX
>>  	pxa_suspend(PWRMODE_DEEPSLEEP);
>> +#endif
>> +#ifdef CONFIG_ARCH_PXA3XX
>> +	pxa3xx_suspend(PXA3xx_PM_S3D4C4);
>> +#endif
>
> 	if (cpu_is_*())
>
> instead of ifdefs?
That was my first try, but compilation did fail. Yet your other suggestion
(separate by SoC type) could take care of it.

>
>>  	unreachable();
>>  }
>> diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c
>
> Better mfp-pxa3xx.c analog to mfp-pxa2xx.c?
Definitely, for v2.

> Instead of separating the source files by functionality you could
> separate them by SoC type. This would reduce the need for ifdefs.
Yes, good idea.

I'll create pxa3xx.c and pxa2xx.c, and stuff them with poweroff(),
reset_source(), etc ..., each with its own variant.

Cheers.

-- 
Robert

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-01-05 20:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04  9:41 Robert Jarzmik
2015-01-04  9:41 ` [PATCH v2 2/2] ARM: pxa: add the zylonite board Robert Jarzmik
2015-01-05 13:12 ` [PATCH v2 1/2] ARM: pxa: add pxa3xx architecture Sascha Hauer
2015-01-05 20:35   ` Robert Jarzmik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj9x3qz8.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox