Re: [PATCH 0/2] drivers/mtd: add a core

[Robert Jarzmik <robert.jarzmik@free.fr>]

Sascha Hauer <s.hauer@pengutronix.de> writes:

> So if no protests from other side come we can:
>
> - git mv drivers/mtd/nand/nand.c drivers/mtd/core.c
> - replace the oob device with the data+oob device
> - apply whatever other fixes you need
Sure, that would be great.
If no one complains in the next 5 days, I'll provide a V2 of the patch doing it
your way :
 - patch1: move nand.c into core.c
 - patch2: convert all existing nand devices to core.c (ie. add_mtd_device)
   *Warning* The device will be named "/dev/mtd<N>" and not "/dev/nand<N>". This
   can break things, especially if legacy board code relies on the "nand" device
   naming. Solutions:
     (a) Add a parameter to add_mtd_device: add_mtd_device(struct mtd_info *mtd,
     char *basename)
         => if basename == NULL, then use "mtd"
         => if basename != NULL, use basename for device name
     (b) Create a specialized add_nand_device()
     (c) Convert all legacy boards from "nand" to "mtd"
 - patch3: amend core.c to bring in the device+oob function

Does it look good to you ?

Cheers.

-- 
Robert

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox