Re: [PATCH v2 14/21] ARM: exceptions: make in-binary exception table const

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 1/6/26 1:53 PM, Sascha Hauer wrote:
> When making the .text section const we can no longer modify the code.
> On ARMv5/v6 we finally use a copy of the exception table anyway, so
> instead of modifying it in-place and copy afterwards, copy it first and
> then modify it.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> +/* This struct must match the assembly exception table in exceptions_32.S */

One could add offset definitions to arch/arm/lib/asm-offsets.c and reuse
it this way, but I am fine duplicating it.

>  #ifdef CONFIG_ARM_EXCEPTIONS
> -void arm_fixup_vectors(void);
> +void arm_fixup_vectors(void *table);
>  ulong arm_get_vector_table(void);
>  #else
> -static inline void arm_fixup_vectors(void)
> +static inline void arm_fixup_vectors(void *table)
>  {
>  }

I am still wondering why the assemble code couldn't emit relocations,
but let's get this over with for now.

Cheers,
Ahmad

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |