From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 11 Mar 2024 14:59:08 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rjgBI-0019KK-2b for lore@lore.pengutronix.de; Mon, 11 Mar 2024 14:59:08 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjgBI-0002tO-65 for lore@pengutronix.de; Mon, 11 Mar 2024 14:59:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F91+7knfAxiLgWFhVcmWZgxOdbPYcWCZAjIveG+ofqQ=; b=H2zExagj7pouduWjeCIOKsi938 zB6cqVg7S0VoVnCXG45p7pmc7TaOQQjTTrI0KltJdJEqsu1AG0wJbbj+Mi0ZQTUZ97qSESnQeJv8f dw1RVwRuhp0MkSjF2YNLAoSB2X55R3j5yqT2m0wszSyoRKeuyAbcMEcbKCMBMl+Xu4mu+MofIqz/B 2LgC92kCUNgNN6lPIFqtASuNWiMGkxumWuMTwbUmG4VwarXV2MYnhbWBgsya7yCvUhmUxDKEw7QGR o09tsOEa8Mc/S9qtiYvaZb36FJELgN/zWaC2GBKaP53aYgk6FBI4Nd9OYCHwxVPXO1PKdQPToSXQX ublOzeSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjgAi-00000001hu5-1UPI; Mon, 11 Mar 2024 13:58:32 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjgAc-00000001hrJ-35LX for barebox@lists.infradead.org; Mon, 11 Mar 2024 13:58:30 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rjgAa-0002Hy-P0; Mon, 11 Mar 2024 14:58:24 +0100 Message-ID: <89f1c7a4-ebe3-4ce9-a5d6-ebbc6187d982@pengutronix.de> Date: Mon, 11 Mar 2024 14:58:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Stefan Kerkmann , Sascha Hauer , BAREBOX References: <20240311-karo-imx8mp-som-board-upstreaming-v1-0-7c77f9ba02e5@pengutronix.de> <20240311-karo-imx8mp-som-board-upstreaming-v1-6-7c77f9ba02e5@pengutronix.de> <5dd3c20d-26c4-4cd0-89a1-f922d5ddae02@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <5dd3c20d-26c4-4cd0-89a1-f922d5ddae02@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240311_065826_923437_200425BA X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 6/6] arm: imx8mp: add karo electronics qsxp imx8mp som support X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Stefan, On 11.03.24 14:32, Stefan Kerkmann wrote: > Hello Ahmad, > > On 11.03.24 11:13, Ahmad Fatoum wrote: >> Hello Stefan, >> >> On 11.03.24 10:10, Stefan Kerkmann wrote: >>> From: Marc Kleine-Budde >>> >>> The Ka-Ro QSXP is a i.MX8M Plus solder down system on module. This >>> commit adds support for the SOM on the QSBASE4 RDK. >>> >>> [1]: https://www.karo-electronics.de/qsxp >>> >>> Signed-off-by: Marc Kleine-Budde >>> Signed-off-by: Stefan Kerkmann >>> --- >>> arch/arm/boards/Makefile | 1 + >>> arch/arm/boards/karo-qsxp-ml81/Makefile | 4 + >>> arch/arm/boards/karo-qsxp-ml81/board.c | 35 + >>> .../flash-header-karo-qsxp-ml81.imxcfg | 9 + >>> arch/arm/boards/karo-qsxp-ml81/lowlevel.c | 102 ++ >>> arch/arm/boards/karo-qsxp-ml81/lowlevel.h | 8 + >>> arch/arm/boards/karo-qsxp-ml81/lpddr4-timing.c | 1597 ++++++++++++++++++++ >> >> If QSXP is the SoM name, rename the folder name to drop ml81. >> > > See reply to patch 5/6, the full manufacturer part number is `QSXP-ML81` > therefore I vote to keep the `ml81` part. Ok, can you call it QSXP-ML81 in the commit message? >> JFYI, if you want to dynamic frequency scaling for DDR, you'll need some >> more entries here. >> > > I'm unfamiliar with dynamic frequency scaling, so I'm not sure if we > need/want more for a first support of this SOM? No, you don't need more. This is Just For Your Information. Dynamic Frequency Scaling can be useful to reduce power usage. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |