mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Jules Maselbas <jmaselbas@kalray.eu>, Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] base: driver: fix double removal of child devices
Date: Mon, 13 Sep 2021 12:18:49 +0200
Message-ID: <8ab1e448-a21b-38d0-94fa-65caf30b95d4@pengutronix.de> (raw)
In-Reply-To: <20210913100836.GD8023@tellis.lin.mbt.kalray.eu>

Hello Jules,

On 13.09.21 12:08, Jules Maselbas wrote:
> Hi Ahmad,
> 
> On Mon, Sep 13, 2021 at 10:29:42AM +0200, Ahmad Fatoum wrote:
>> Child devices like an ext4 file system on a partition may be removed
>> twice: Once because they're in the active devices list and then once
>> more, because unregister_device is called for the children of its parent.
>>
>> As struct bus_type::remove clears association of a driver with its
>> device, we can set struct device_d::driver to NULL. unregister_device
>> will then skip the second dev->bus->remove.
>>
>> Fixes: 29f1c211d86c ("fs: don't free device in remove callback")
>> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
>> ---
>>  drivers/base/driver.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/base/driver.c b/drivers/base/driver.c
>> index 0e04ef36868d..0fedb30161b4 100644
>> --- a/drivers/base/driver.c
>> +++ b/drivers/base/driver.c
>> @@ -512,7 +512,10 @@ static void devices_shutdown(void)
>>  
>>  	list_for_each_entry(dev, &active, active) {
>>  		if (dev->bus->remove)
>> +		if (dev->bus->remove) {
> I think there is a typo here, this line is duplicated.

You're right. It still worked because the condition was duplicated... ^^'

I sent out a revised v2.

Thanks,
Ahmad

> 
>>  			dev->bus->remove(dev);
>> +			dev->driver = NULL;
>> +		}
>>  	}
>>  }
>>  devshutdown_exitcall(devices_shutdown);
>> -- 
>> 2.33.0
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
>>
> 
> 
> 
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-09-13 10:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  8:29 Ahmad Fatoum
2021-09-13 10:08 ` Jules Maselbas
2021-09-13 10:18   ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ab1e448-a21b-38d0-94fa-65caf30b95d4@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    --cc=jmaselbas@kalray.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git