mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: maudspierings@gocontroll.com,
	Sascha Hauer <s.hauer@pengutronix.de>,
	BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] scripts: imx: Makefile.mingw64: add _GNU_SOURCE
Date: Mon, 1 Dec 2025 11:29:22 +0100	[thread overview]
Message-ID: <8c9282fe-e615-4c5f-884f-435b2726844c@pengutronix.de> (raw)
In-Reply-To: <20251201-imx_usb-v2-1-95ec2a0e8694@gocontroll.com>



On 12/1/25 11:26 AM, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@gocontroll.com>
> 
> imx.c uses asprintf which requires _GNU_SOURCE to be defined, include
> defines.h to define it.
> 
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  scripts/imx/Makefile.mingw64 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/imx/Makefile.mingw64 b/scripts/imx/Makefile.mingw64
> index e012d833f1..101b39e917 100644
> --- a/scripts/imx/Makefile.mingw64
> +++ b/scripts/imx/Makefile.mingw64
> @@ -30,7 +30,7 @@ $(if $(obj),, \
>  # $(realpath ...) resolves symlinks
>  obj := $(realpath $(obj))
>  
> -CPPFLAGS := -I $(LIBUSB_MINGW)/include/libusb-1.0 -I $(src)/../include/ -I $(src)/../../include/mach/
> +CPPFLAGS := -I $(LIBUSB_MINGW)/include/libusb-1.0 -I $(src)/../include/ -I $(src)/../../include/mach/ -include $(src)/../include/defines.h
>  LDFLAGS := -L $(LIBUSB_MINGW)/lib -lusb-1.0 -static
>  
>  OBJECTS := $(addprefix $(obj)/, imx.o imx-usb-loader.o)
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2025-12-01 10:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01 10:26 [PATCH v2 0/3] scripts: imx: imx-usb-loader: fix mingw compilation Maud Spierings via B4 Relay
2025-12-01 10:26 ` [PATCH v2 1/3] scripts: imx: Makefile.mingw64: add _GNU_SOURCE Maud Spierings via B4 Relay
2025-12-01 10:29   ` Ahmad Fatoum [this message]
2025-12-01 10:26 ` [PATCH v2 2/3] scripts: imx: add pread implementation for mingw target Maud Spierings via B4 Relay
2025-12-01 11:00   ` Ahmad Fatoum
2025-12-01 10:26 ` [PATCH v2 3/3] gitignore: ignore *.exe Maud Spierings via B4 Relay
2025-12-01 10:42   ` Ahmad Fatoum
2025-12-01 11:03 ` [PATCH v2 0/3] scripts: imx: imx-usb-loader: fix mingw compilation Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c9282fe-e615-4c5f-884f-435b2726844c@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=maudspierings@gocontroll.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox