From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 07 Jun 2021 17:48:15 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lqHU7-0001kP-8i for lore@lore.pengutronix.de; Mon, 07 Jun 2021 17:48:15 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqHU3-0000Lf-9X for lore@pengutronix.de; Mon, 07 Jun 2021 17:48:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=C14L3/gBMMCtIMUq9UZfAU5PBdSr+OCEv0bQMVqpcFQ=; b=fGyrKw5q+bu/IEkppGiZR9M7ce NV11qDwIK21k4D9eXY7hWr9oGwEGlImDw/ngYl3M82J19Q2+ZUoGR/VMUTw9c5d+U3GJLH4NtLW11 PKik+bXZTc+Me0Q7stDo4TweEuxOxSp+O/V2Inbyx9mzWjpVgyKoV8q+lX0o7RsT5HqtVzjqBJA9w bzrRaVCf3ckFZP9QSTw3xW1LgSwAed4d7GQmQIsXYS+9Pn6Yppp0DVqZ6xcXGn8dichyPmye48n7t fEDCY5eFL90m/anFq0cN9YmVifdj+rXAuLNKwW5A1glnX0ozyGDqgZFsZWl9jUXDepCLo85namgV7 48LG9HMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqHSO-004JwV-Jh; Mon, 07 Jun 2021 15:46:28 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqHSB-004Jtu-2u for barebox@lists.infradead.org; Mon, 07 Jun 2021 15:46:18 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lqHS9-0000CR-24; Mon, 07 Jun 2021 17:46:13 +0200 To: Sascha Hauer , Barebox List References: <20210607141256.24801-1-s.hauer@pengutronix.de> From: Ahmad Fatoum Message-ID: <8d61da9c-a55a-9c98-2918-7f9c95df324f@pengutronix.de> Date: Mon, 7 Jun 2021 17:46:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210607141256.24801-1-s.hauer@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_084615_160195_C162120A X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] clk: bail out early when rate is already desired one X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 07.06.21 16:12, Sascha Hauer wrote: > Return successfully from clk_set_rate() when the rate is already the > desired one. This prevents a failure in clk_set_rate() when the current > clock doesn't have a set_rate hook. > > Signed-off-by: Sascha Hauer > --- > drivers/clk/clk.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 8b90f30486..ba726c342c 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -169,6 +169,9 @@ int clk_set_rate(struct clk *clk, unsigned long rate) > if (IS_ERR(clk)) > return PTR_ERR(clk); > > + if (clk_get_rate(clk) == clk_round_rate(clk, rate)) > + return 0; > + > if (!clk->ops->set_rate) > return -ENOSYS; This means we can drop 459bf1fd31da ("ARM: clk: rk3188: don't set same clk rate twice"), right? -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox