From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 23 Feb 2026 13:07:13 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuUiW-004pIZ-39 for lore@lore.pengutronix.de; Mon, 23 Feb 2026 13:07:13 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vuUiX-0003Bw-9B for lore@pengutronix.de; Mon, 23 Feb 2026 13:07:13 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eBj1wzw/MA3758BCTkZUGKcvURcZ4ELi++Q5QswvlEk=; b=oChz5PxhWW82KhF0dkB0VI2xRk paDk2XVHW7dDsjB2QQCgiqiiOz12HQXFnAMdWaEKMzGF0u6jtdCznxIPYkalA5Aybw592A58mzmBS MdBpaSD3EFV3gO1X1P+oEtx45JmQ+RR9BDhuAKRHqFf5u1ERD1GZSDMqt/om/IyHrhUEZr6KOAFYs vqqh0Y30VPJXDlqAFADrtP8S6y5R/Rcvg3cB1Hnkoz0mLt7F/rBdh4L751S9bdBrSyVqO7H/qmud1 o9HfM3fSvI5FSOl3gn/eASKTOeXBRhP35QAVYDOgY320HR+bIYKZ+7BC5bRqlE1evezQDi8Ktcrcg zz0y3qig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuUi7-00000000FnJ-2X0H; Mon, 23 Feb 2026 12:06:47 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuUi5-00000000Fme-3A70 for barebox@lists.infradead.org; Mon, 23 Feb 2026 12:06:46 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vuUi4-00036P-B8; Mon, 23 Feb 2026 13:06:44 +0100 Message-ID: <8d7c7889-072f-4391-bd06-fdc4da32d814@barebox.org> Date: Mon, 23 Feb 2026 13:06:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer Cc: barebox@lists.infradead.org, "Claude Opus 4.6" References: <20260223113446.638135-1-a.fatoum@barebox.org> <20260223113446.638135-4-a.fatoum@barebox.org> From: Ahmad Fatoum Content-Language: en-US, de-DE, de-BE In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260223_040645_794527_2D5104B5 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 3/4] MAKEALL: error out on options placed after the defconfig argument X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 2/23/26 1:05 PM, Sascha Hauer wrote: > On Mon, Feb 23, 2026 at 12:52:52PM +0100, Ahmad Fatoum wrote: >> Hi, >> >> On 2/23/26 12:50 PM, Sascha Hauer wrote: >>> On Mon, Feb 23, 2026 at 12:31:34PM +0100, Ahmad Fatoum wrote: >>>> getopts stops parsing at the first non-option argument, so options >>>> like -k after the defconfig name silently end up as positional >>>> arguments. For bare defconfigs these get misinterpreted as pytest >>>> options and are silently ignored, leading to a build without the >>>> intended configuration. >>>> >>>> Detect this by checking for trailing arguments when any positional >>>> argument is a bare defconfig (not a labgrid .yaml config, where >>>> extra arguments are intentionally forwarded to pytest). >>> >>> Can't we use getopt for MAKEALL instead of getopts? getopt just does the >>> right thing. >> >> When using MAKEALL with a labgrid yaml instead of a defconfig, it >> derives the defconfig name and interprets the options after the yaml as >> pytest options, so use of getopt would break that. > > You can use -- as final argument which stops getopt parsing. Fair enough, I think 1,2,4 are good to go though? I will rework 3/4 later. Thanks, Ahmad > > Sascha > >> >> Cheers, >> Ahmad >> >>> >>> Sascha >>> >>>> >>>> Co-Authored-By: Claude Opus 4.6 >>>> Signed-off-by: Ahmad Fatoum >>>> --- >>>> MAKEALL | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/MAKEALL b/MAKEALL >>>> index c36aed625820..dd0b7f8003cc 100755 >>>> --- a/MAKEALL >>>> +++ b/MAKEALL >>>> @@ -440,6 +440,15 @@ else >>>> >>>> configs+=($i) >>>> done >>>> + if [ ${#pytest_opts[@]} -gt 0 ]; then >>>> + for i in "${configs[@]}"; do >>>> + if ! [[ $i =~ .yaml$ ]]; then >>>> + echo "error: unexpected arguments after defconfig: ${pytest_opts[*]}" >&2 >>>> + echo "hint: place all options before the defconfig argument" >&2 >>>> + exit 1 >>>> + fi >>>> + done >>>> + fi >>>> for i in "${configs[@]}"; do >>>> config=$i >>>> if [[ $i =~ ^.*/([^/]+)/([^@]*@|)([^.]+).yaml$ ]]; then >>>> -- >>>> 2.47.3 >>>> >>>> >>>> >>> >> >> >