Re: [PATCH 3/3] test: self: add JSON Web Token tests

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 02.11.23 08:20, Sascha Hauer wrote:
> Hi Ahmad,
> 
> On Mon, Oct 23, 2023 at 04:31:23PM +0200, Ahmad Fatoum wrote:
>> diff --git a/test/self/Makefile b/test/self/Makefile
>> index 8168abf26278..24e78a186513 100644
>> --- a/test/self/Makefile
>> +++ b/test/self/Makefile
>> @@ -9,6 +9,7 @@ obj-$(CONFIG_SELFTEST_OF_MANIPULATION) += of_manipulation.o of_manipulation.dtb.
>>  obj-$(CONFIG_SELFTEST_ENVIRONMENT_VARIABLES) += envvar.o
>>  obj-$(CONFIG_SELFTEST_FS_RAMFS) += ramfs.o
>>  obj-$(CONFIG_SELFTEST_JSON) += json.o
>> +obj-$(CONFIG_SELFTEST_JWT) += jwt.o jwt_test.pem.o
>>  obj-$(CONFIG_SELFTEST_DIGEST) += digest.o
>>  obj-$(CONFIG_SELFTEST_MMU) += mmu.o
>>  obj-$(CONFIG_SELFTEST_STRING) += string.o
>> @@ -16,5 +17,13 @@ obj-$(CONFIG_SELFTEST_SETJMP) += setjmp.o
>>  obj-$(CONFIG_SELFTEST_REGULATOR) += regulator.o test_regulator.dtbo.o
>>  obj-$(CONFIG_SELFTEST_TEST_COMMAND) += test_command.o
>>  
>> -clean-files := *.dtb *.dtb.S .*.dtc .*.pre .*.dts *.dtb.z
>> +ifdef REGENERATE_RSATOC
>> +
>> +$(obj)/jwt_test.pem.c_shipped: $(src)/jwt_test.pem FORCE
>> +	$(call if_changed,rsa_keys,$(basename $(target-stem)):$<,-s)
>> +
>> +endif
>> +
>> +clean-files := *.dtb *.dtb.S .*.dtc .*.pre .*.dts *.dtb.z *
>                                                             ^^^
> 
> This additional '*' removes parts of the source tree when doing a make
> clean. Was there any intention with this or is this just an accident?

Please revert the line, I think this used to remove an intermediary artifact
that's no longer relevant.

Thanks,
Ahmad

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |