From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 16 Jan 2025 11:16:06 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tYMuz-000Yjn-22 for lore@lore.pengutronix.de; Thu, 16 Jan 2025 11:16:06 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tYMuz-0002T7-O6 for lore@pengutronix.de; Thu, 16 Jan 2025 11:16:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XRVAPuLNHDKyRrE12E1pd0UjpOu4ZZeU5cunx79Lfo0=; b=r1gco0YcJLisbXKc6Nk5SpLrwA 0FWSXrRA7Bwohz8fGvpHggUUowD1aZZy+gKctn3Ueq2EA1ZNO6dTqIf3T8XoK2xw+fE/zFdObVnRs eJJyj0vzd+JW01OPPaTwsvCbi60+uG0pofKlkxaI/KRJbe+jKNwm0tykmHmgM8LEJwNO58M4HcbNm hAqR9ngGeIpVNsn1l23EmXxDNsDoOUifkLXZfNZrApjtSohMQEmIgLPb//zeeF32CM/iF6q7Ajzjm u4cUDUDn5HMk4bFIZqDATGmXa5NWt7nvdmUFRYzWAO4Rc/WPFJcNZ+cFEQaMjcLapArulShiocQpX IA6NDjXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYMuX-0000000ETIc-3siZ; Thu, 16 Jan 2025 10:15:37 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYMuU-0000000ETIA-3Zrq for barebox@lists.infradead.org; Thu, 16 Jan 2025 10:15:36 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tYMuS-0002On-3z; Thu, 16 Jan 2025 11:15:32 +0100 Message-ID: <8fa45a04-22b4-4e15-9851-d2490162e5e0@pengutronix.de> Date: Thu, 16 Jan 2025 11:15:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sascha Hauer Cc: barebox@lists.infradead.org, Rouven Czerwinski , Marco Felsch , Stefan Kerkmann References: <20250106113340.1224335-1-bst@pengutronix.de> From: Bastian Krause In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_021534_891055_C23A85F6 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] scripts: imx: pass semicolons as substitute chars to compiler macros for CSF templating X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 1/16/25 11:01 AM, Sascha Hauer wrote: > On Fri, Jan 10, 2025 at 05:18:51PM +0100, Bastian Krause wrote: >> Hi Sascha, >> >> On 1/10/25 12:31 PM, Sascha Hauer wrote: >>> On Mon, Jan 06, 2025 at 12:33:40PM +0100, Bastian Krause wrote: >>>> With CONFIG_HAB_CERTS_ENV=y, paths and PKCS#11 URIs to the HAB >>>> certificates are taken from environment variables (allowing for better >>>> integration with build systems). In this case these values are passed >>>> internally via compiler macros (-D) to the imx-image host tool. PKCS#11 >>>> URIs usually contain semicolons. Semicolons, however, cannot be passed >>>> via compiler macros and cannot be escaped. >>> >>> Try harder. >>> >>> gcc -DFOO='"bar;baz"' test.c >>> >>> #include >>> >>> int main(void) >>> { >>> printf(FOO); >>> } >>> >>> Works as expected, so does it work when you add single quotes around the >>> URI? >> >> This actually works: >> >> --- a/scripts/Makefile.lib >> +++ b/scripts/Makefile.lib >> @@ -570,8 +570,8 @@ imxcfg_cpp_flags = -Wp,-MD,$(depfile) -nostdinc -x >> assembler-with-cpp \ >> $(call overwrite-hab-env,CONFIG_HABV3_CSF_CRT_DER) \ >> $(call overwrite-hab-env,CONFIG_HABV3_IMG_CRT_DER) \ >> $(call overwrite-hab-env,CONFIG_HABV4_TABLE_BIN) \ >> - $(call overwrite-hab-env,CONFIG_HABV4_CSF_CRT_PEM) \ >> - $(call overwrite-hab-env,CONFIG_HABV4_IMG_CRT_PEM) \ >> + -DCONFIG_HABV4_CSF_CRT_PEM='"$(CONFIG_HABV4_CSF_CRT_PEM)"' \ >> + -DCONFIG_HABV4_IMG_CRT_PEM='"$(CONFIG_HABV4_IMG_CRT_PEM)"' \ >> $(call overwrite-fit-env,CONFIG_BOOTM_FITIMAGE_PUBKEY) \ >> >> dcd-tmp = $(subst $(comma),_,$(dot-target).dcd.tmp) >> >> >> But I had no luck integrating the single quote approach in overwrite- >> hab-env. Maybe my quoting/escaping fu is not strong enough. Could you >> take a look? > > Took some time, but it should work now. See the patch I just sent. Nice, thanks! I'll give it a spin and will let you know if it works for me. Regards, Bastian -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |