From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 09 Jun 2023 11:30:03 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7YRY-00GzRI-UT for lore@lore.pengutronix.de; Fri, 09 Jun 2023 11:30:03 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7YRW-0001m4-Fs for lore@pengutronix.de; Fri, 09 Jun 2023 11:30:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To:Subject :MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SrLj0PY1qp7b9aRPxJkdDqMxHTqdEVqXFMe2PcUi9a0=; b=cij4dDiFmxVelo CGuXt7WATezksNF7X6tQx185LSqCZhURz80WFIP1kzxsRJM/u72lZQN6phWdoSfCnjb2vUq+lP4RV ncP6Z8SLSwyByXiX6DR/AkbfoGaQ2DbL2cH5ncUuL+2mhJWJiVBQ5NJUeqCXyTNvNAw6s0KuYmWNC yIDerBpaKa32vKdgfBOeQbvJfMrFVSPr43J5v2aH0P0/68AdLYXvlL4tg4xpiZNs3QkYgSSBeAUSj EtHDDwxjEr55MIZPLpPK4VwWACvXXq3OKk0/ZSDsDq7kRy75bYRfLjdWiKqVj8rT8he9dY0pI6eQN IatH3xZzMuanLJdm6zXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7YQg-00CPjT-27; Fri, 09 Jun 2023 09:29:10 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7YQb-00CPgO-1a for barebox@lists.infradead.org; Fri, 09 Jun 2023 09:29:08 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q7YQV-0001fC-5N; Fri, 09 Jun 2023 11:28:59 +0200 Message-ID: <917a2465-b754-b7f4-d51b-53bd2c5ba7e5@pengutronix.de> Date: Fri, 9 Jun 2023 11:28:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Denis Orlov References: <20230607051155.3175-1-denorl2009@gmail.com> <20230607051155.3175-3-denorl2009@gmail.com> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_022905_528942_994FAA80 X-CRM114-Status: GOOD ( 25.39 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: barebox@lists.infradead.org Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 2/3] test: mips: add QEMU Malta 64le labgrid config X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 09.06.23 11:17, Denis Orlov wrote: > On Fri, 9 Jun 2023 at 10:21, Ahmad Fatoum wrote: >> >> On 09.06.23 09:14, Denis Orlov wrote: >>> Hello Ahmad, >>> >>> On Fri, 9 Jun 2023 at 09:36, Ahmad Fatoum wrote: >>>> >>>> On 07.06.23 06:59, Denis Orlov wrote: >>>>> Signed-off-by: Denis Orlov >>>>> --- >>>>> test/mips/qemu-malta64el_defconfig.yaml | 22 ++++++++++++++++++++++ >>>>> 1 file changed, 22 insertions(+) >>>>> create mode 100644 test/mips/qemu-malta64el_defconfig.yaml >>>>> >>>>> diff --git a/test/mips/qemu-malta64el_defconfig.yaml b/test/mips/qemu-malta64el_defconfig.yaml >>>>> new file mode 100644 >>>>> index 0000000000..22562d5b7a >>>>> --- /dev/null >>>>> +++ b/test/mips/qemu-malta64el_defconfig.yaml >>>>> @@ -0,0 +1,22 @@ >>>>> +targets: >>>>> + main: >>>>> + drivers: >>>>> + QEMUDriver: >>>>> + qemu_bin: qemu >>>>> + machine: malta >>>>> + cpu: 5KEf >>>>> + memory: 256M >>>>> + bios: barebox-qemu-malta.img.swapped >>>>> + extra_args: '' >>>>> + BareboxDriver: >>>>> + prompt: 'barebox@[^:]+:[^ ]+ ' >>>>> + bootstring: 'commandline:' >>>>> + BareboxTestStrategy: {} >>>>> + features: >>>>> + - virtio-pci >>>> >>>> Did you test virtio PCI? I don't see it enabled in the defconfig. >>> >>> Nope, I didn't. I must have copied this from the 32-bit malta config >>> file. However, I see that its defconfig also lacks VIRTIO_PCI, so should >>> those be removed from both labgrid configs? >>> >>> Besides, judging from the virtio PCI Kconfig option depends, there seem >>> to be some issues with virtio PCI on MIPS without CONFIG_MMU set. Is the >>> lack of VIRTIO_PCI option in 32-bit malta defconfig related to that? >> >> Ah, right. test/emulate.pl reads virtio-pci feature to decide what Virt I/O >> transport to use. Maybe the MMU incompatibility is fixed now with your >> recent DMA rework or maybe we still have 1:1 mapping assumptions in the >> virtio code itself. If you could give it a quick test with CONFIG_MMU=n >> and see if it works, that would be great. Something like this should do it: >> >> /usr/bin/qemu-system-mips64el -M malta -cpu 5KEf -m 256M \ >> -bios barebox-qemu-malta.img.swapped -serial mon:stdio -trace file=/dev/null \ >> -drive if=none,file=/src/barebox-rockchip/somealigned.img,format=raw,id=hd0 \ >> -device virtio-blk-pci,disable-legacy=on,disable-modern=off,drive=hd0 >> >> (Above was generated by ./test/emulate.pl $config -n --blk=somealigned.img) >> >> You should see a /dev/virtioblk* device if everything is enabled and working. > > Yeah, it seems that this works on both CONFIG_MMU=y and CONFIG_MMU=n now. > The drive mounts successfully and I am able to look at its contents with > "ls". So, does this mean that we should enable the VIRTIO_PCI option in > malta defconfigs? Even for 32-bit? Ye, then we can drop the depends line in VIRTIO_PCI and enable it in the MIPS defconfigs. Thanks for testing! Ahmad > >> >> Cheers, >> Ahmad >> >>> >>> Regards, >>> Denis >>> >>>> >>>>> +images: >>>>> + barebox-qemu-malta.img.swapped: !template "$LG_BUILDDIR/images/barebox-qemu-malta.img.swapped" >>>>> +tools: >>>>> + qemu: /usr/bin/qemu-system-mips64el >>>>> +imports: >>>>> + - ../strategy.py >>>> >>>> -- >>>> Pengutronix e.K. | | >>>> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >>>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >>>> >>> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |