Re: [PATCH] globalvar: add a globalvar_get helper

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 21.09.23 16:16, Ahmad Fatoum wrote:
> We have functions to set global variables, but none to get them, but
> having a globalvar_get helper could be useful to get code size down when
> global variables are disabled, as globalvar_get("var") would be optimized
> out, while getenv("global.var") wouldn't. Therefore, add the helper.

Gentle ping.

> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  include/globalvar.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/globalvar.h b/include/globalvar.h
> index 36a7c7006c76..5fdb70fca911 100644
> --- a/include/globalvar.h
> +++ b/include/globalvar.h
> @@ -10,6 +10,12 @@
>  extern struct device global_device;
>  
>  #ifdef CONFIG_GLOBALVAR
> +
> +static inline const char *globalvar_get(const char *name)
> +{
> +	return dev_get_param(&global_device, name);
> +}
> +
>  int globalvar_add_simple(const char *name, const char *value);
>  
>  void globalvar_remove(const char *name);
> @@ -41,6 +47,11 @@ void dev_param_init_from_nv(struct device *dev, const char *name);
>  void globalvar_alias_deprecated(const char *newname, const char *oldname);
>  
>  #else
> +static inline const char *globalvar_get(const char *name)
> +{
> +	return NULL;
> +}
> +
>  static inline int globalvar_add_simple(const char *name, const char *value)
>  {
>  	return 0;

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |