Re: [PATCH 1/3] ARM: move blob_is_arm_boarddata() to include

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 30.04.24 12:53, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  arch/arm/cpu/start.c               | 7 -------
>  arch/arm/include/asm/barebox-arm.h | 7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/cpu/start.c b/arch/arm/cpu/start.c
> index 6d0a7cfc6b..c13e93c243 100644
> --- a/arch/arm/cpu/start.c
> +++ b/arch/arm/cpu/start.c
> @@ -36,13 +36,6 @@ static unsigned long arm_membase;
>  static void *barebox_boarddata;
>  static unsigned long barebox_boarddata_size;
>  
> -static bool blob_is_arm_boarddata(const void *blob)
> -{
> -	const struct barebox_arm_boarddata *bd = blob;
> -
> -	return bd->magic == BAREBOX_ARM_BOARDDATA_MAGIC;
> -}
> -
>  const struct barebox_boarddata *barebox_get_boarddata(void)
>  {
>  	if (!barebox_boarddata || !blob_is_arm_boarddata(barebox_boarddata))
> diff --git a/arch/arm/include/asm/barebox-arm.h b/arch/arm/include/asm/barebox-arm.h
> index 4d70360b91..67f2b6ac45 100644
> --- a/arch/arm/include/asm/barebox-arm.h
> +++ b/arch/arm/include/asm/barebox-arm.h
> @@ -32,6 +32,13 @@ void __noreturn barebox_arm_entry(unsigned long membase, unsigned long memsize,
>  #define barebox_arm_boarddata		barebox_boarddata
>  #define BAREBOX_ARM_BOARDDATA_MAGIC	BAREBOX_BOARDDATA_MAGIC
>  
> +static inline bool blob_is_arm_boarddata(const void *blob)
> +{
> +	const struct barebox_arm_boarddata *bd = blob;
> +
> +	return bd->magic == BAREBOX_ARM_BOARDDATA_MAGIC;
> +}
> +
>  u32 barebox_arm_machine(void);
>  
>  unsigned long arm_mem_ramoops_get(void);

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |