Re: [PATCH v2] ARM: rockchip: Add support for Pine64 PineTab 2

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Dang,

On 03.12.24 11:24, Dang Huynh wrote:
> The Pine64 PineTab 2 tablet is basically the Quartz64 but as
> a finished product.
> 
> There are (currently) two revisions, v0.1 and v2.0.
> 
> v0.1 was sent to developers and there are a few units around
> (probably less than 10?)
> 
> v2.0 is the consumer available version, this version changed the
> display reset pin and hooked WLAN/BT chip to a GPIO.
> 
> Signed-off-by: Dang Huynh <danct12@riseup.net>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> +	if (bootsource == BOOTSOURCE_MMC && instance == 0)
> +		of_device_enable_path("/chosen/environment-sd");
> +	else
> +		of_device_enable_path("/chosen/environment-emmc");
> +
> +	rockchip_bbu_mmc_register("sd", 0, "/dev/mmc0");
> +	rockchip_bbu_mmc_register("emmc", BBU_HANDLER_FLAG_DEFAULT, "/dev/mmc1");

I still think it's useful to set BBU_HANDLER_FLAG_DEFAULT for the SD-card when
SD-booted, i.e.:

	int sd_flags = 0, emmc_flags = 0;	

	if (bootsource == BOOTSOURCE_MMC && instance == 0) {
		of_device_enable_path("/chosen/environment-sd");
		sd_flags = BBU_HANDLER_FLAG_DEFAULT;
	} else {
		of_device_enable_path("/chosen/environment-emmc");
		emmc_flags = BBU_HANDLER_FLAG_DEFAULT;
	}

	rockchip_bbu_mmc_register("sd", sd_flags, "/dev/mmc0");
	rockchip_bbu_mmc_register("emmc", emmc_flags, "/dev/mmc1");


But I don't have the board, so it's up to you.

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |