From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 12 Dec 2024 09:27:43 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tLeXv-0077FJ-19 for lore@lore.pengutronix.de; Thu, 12 Dec 2024 09:27:43 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLeXv-0002eB-9e for lore@pengutronix.de; Thu, 12 Dec 2024 09:27:43 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zhB3+LxkuItv/Pp9U/64wRXpoJeD/1ipxcxS4/87JKA=; b=bgTEKjhf/fEnj/agfNt4fyxaIW nVx+1SQubpdSXYC7YKecOKDLAf63eUtsjUaB88MQZ42sL29tIx4TrKW5QyCI+AvL4ug7t/aqYrOiv AWzOSHclknRNSudfRRxhq4o/eIG05g48ZqYVfuJ2B/iEWxA9MnkoP3f1739Igc+CY7W8Gc7w+ehY2 FV43zwgGwrl/x4ya9j5QWep3LSu1r99g362ZEpohfD37vHn38wdScOVERAbuhtKV12cA//PUO1AMu K9GpBS8Exq4hzMxWZAVmiQI2Be3vuruVxsHfAf/pEWpbDsxheDJQwP8cQnhgYpCNbNCky3T0vG/kI KyRlZL1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tLeXT-0000000HIZf-1ETb; Thu, 12 Dec 2024 08:27:15 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tLeT2-0000000HHh4-2aDw for barebox@lists.infradead.org; Thu, 12 Dec 2024 08:22:41 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tLeT1-0001qV-EV; Thu, 12 Dec 2024 09:22:39 +0100 Message-ID: <97b4b4de-fef2-4630-8327-b35029509e04@pengutronix.de> Date: Thu, 12 Dec 2024 09:22:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer , Barebox List References: <20241212081509.2911001-1-s.hauer@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20241212081509.2911001-1-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241212_002240_657000_DD045E37 X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] images: add missing FORCE prerequisite X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Sascha, On 12.12.24 09:15, Sascha Hauer wrote: > With a985c67be ("fixdep: sync with Linux") we now warn about a missing > FORCE prerequisite. Obey that warning and add it to the %.img target. > > Signed-off-by: Sascha Hauer > --- > images/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/images/Makefile b/images/Makefile > index 9007911278..295a5cd713 100644 > --- a/images/Makefile > +++ b/images/Makefile > @@ -146,7 +146,7 @@ $(obj)/barebox.z: $(obj)/../barebox.bin FORCE > missing_fw = $(strip $(wildcard $(obj)/$(FILE_$(@F)).missing-firmware $(basename $(obj)/$(FILE_$(@F))).missing-firmware)) > > .SECONDEXPANSION: > -$(obj)/%.img: $(obj)/$$(FILE_$$(@F)) > +$(obj)/%.img: $(obj)/$$(FILE_$$(@F)) FORCE > $(Q)if [ -z $(FILE_$(@F)) ]; then echo "FILE_$(@F) empty!"; false; fi > $(Q)$(if $(missing_fw),cat $(missing_fw) >$@.missing-firmware,rm -f $@.missing-firmware) Shouldn't this become a command/rule and if_changed / if_changed_rule be then used instead? That's what I did in https://lore.barebox.org/barebox/0b5f4524-975d-427f-b527-6fc543391edb@pengutronix.de/ Let me send a v2. Cheers, Ahmad > $(call if_changed,$(if $(missing_fw),delete,shipped)) -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |