From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlraj-0007tM-O7 for barebox@lists.infradead.org; Thu, 18 Jun 2020 10:16:19 +0000 References: <20200316110008.2909-1-cleger@kalray.eu> <20200316110008.2909-2-cleger@kalray.eu> <20200323101246.GQ3335@pengutronix.de> <1211869674.11432033.1584958869528.JavaMail.zimbra@kalray.eu> <20200325092958.GC27288@pengutronix.de> From: Ahmad Fatoum Message-ID: <980eb1d7-fc8a-4602-aecd-a61d8c78327c@pengutronix.de> Date: Thu, 18 Jun 2020 12:16:13 +0200 MIME-Version: 1.0 In-Reply-To: <20200325092958.GC27288@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] of: base: parse all available memory nodes To: Sascha Hauer Cc: =?UTF-8?Q?Cl=c3=a9ment_Leger?= , Barebox List On 3/25/20 10:29 AM, Sascha Hauer wrote: > On Mon, Mar 23, 2020 at 11:31:26AM +0100, Ahmad Fatoum wrote: >> Hi, >> >> On 3/23/20 11:21 AM, Cl=E9ment Leger wrote: >>>> AFAIK the device_type =3D "memory" property was mandatory in the early >>>> days as well, there shouldn't be any /memory nodes without this >>>> property. Given that, is the add-legacy-node-first still necessary? >>> >>> Agreed, I did that after speaking with someone on IRC which stated >>> (rightfully), that I should keep the legacy behavior if possible. >> >> My concern was about HW that passes a device tree to barebox (PowerPC >> possibly?), where it might have worked before and now won't anymore. >> >> If this is no real concern, it can be removed. > = > There is no PowerPC hardware supported by barebox that passes a device > tree to barebox. I don't think this is necessary. Turns out we had quite a few device trees that lacked a device_type =3D "me= mory" property: https://lists.infradead.org/pipermail/barebox/2020-June/042269.ht= ml The property used to be there, but when upstream removed skeleton.dtsi and either there was no upstream memory node to extend or it was renamed, we ended up with an invalid memory node. > = > Sascha > = -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox