mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org, Sascha Hauer <s.hauer@pengutronix.de>
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [PATCH] ARM: at91: sama5d27_som1_ek: populate MAC address from EEPROM
Date: Wed, 22 Sep 2021 12:54:25 +0200	[thread overview]
Message-ID: <991b390e-3f6d-5c2d-af66-602292dc956e@pengutronix.de> (raw)
In-Reply-To: <20210622080811.28335-1-a.fatoum@pengutronix.de>

Hello Sascha,

On 22.06.21 10:08, Ahmad Fatoum wrote:
> With the latest NVMEM enhancements merged, barebox networking core now
> always consults NVMEM cells referenced in the network controller
> device tree node before it falls back to randomizing a new address.
> 
> The SAM5D27-SOM1 has a 256 byte EEPROM, which holds a MAC address in its
> last 6 bytes. Describe this in the device tree, so boards using the SoM
> will get an unique MAC address assigned and fixed up into the kernel
> device tree. This change can be dropped again when/if the change is
> submitted and applied upstream.

This patch seems to have slipped through the cracks.

Cheers,
Ahmad

> 
> Reported-by: Alexander Dahl <ada@thorsis.com>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/dts/at91-sama5d27_som1.dtsi   | 18 ++++++++++++++++++
>  arch/arm/dts/at91-sama5d27_som1_ek.dts |  2 +-
>  2 files changed, 19 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/dts/at91-sama5d27_som1.dtsi
> 
> diff --git a/arch/arm/dts/at91-sama5d27_som1.dtsi b/arch/arm/dts/at91-sama5d27_som1.dtsi
> new file mode 100644
> index 000000000000..0d84c45f9263
> --- /dev/null
> +++ b/arch/arm/dts/at91-sama5d27_som1.dtsi
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +#include "sama5d2.dtsi"
> +
> +&macb0 {
> +	nvmem-cells = <&macaddr>;
> +	nvmem-cell-names = "mac-address";
> +};
> +
> +&{/ahb/apb/i2c@f8028000/at24@50} {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +
> +	macaddr: mac-address@fa {
> +		reg = <0xfa 6>;
> +		label = "mac-address";
> +	};
> +};
> diff --git a/arch/arm/dts/at91-sama5d27_som1_ek.dts b/arch/arm/dts/at91-sama5d27_som1_ek.dts
> index 97a326dd2b26..1a704b42680f 100644
> --- a/arch/arm/dts/at91-sama5d27_som1_ek.dts
> +++ b/arch/arm/dts/at91-sama5d27_som1_ek.dts
> @@ -4,7 +4,7 @@
>   */
>  
>  #include <arm/at91-sama5d27_som1_ek.dts>
> -#include "sama5d2.dtsi"
> +#include "at91-sama5d27_som1.dtsi"
>  
>  / {
>  	chosen {
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  parent reply	other threads:[~2021-09-22 11:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22  8:08 Ahmad Fatoum
2021-06-22  8:35 ` Alexander Dahl
2021-06-22  9:07   ` Ahmad Fatoum
2021-06-23  6:27     ` Alexander Dahl
2021-09-22 10:54 ` Ahmad Fatoum [this message]
2021-10-04 13:10   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=991b390e-3f6d-5c2d-af66-602292dc956e@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=ada@thorsis.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox