mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX8MP: fix compatible string for koenigbauer,alphajet board
Date: Tue, 30 Apr 2024 14:05:27 +0200	[thread overview]
Message-ID: <9b63e960-845b-4213-873c-da9749f82a64@pengutronix.de> (raw)
In-Reply-To: <20240430102357.1357983-1-rhi@pengutronix.de>

On 30.04.24 12:23, Roland Hieber wrote:
> During the review of the initial board support patch, the SoM compatible
> was changed (and unified) to "congatec,qmx8p" from several different
> incompatible variants. However, the compatible in the alphajet device
> tree contained a different typo and was overlooked, which had the effect
> that the barebox_update handler and the Ethernet fixups were not
> registered on the alphajet board.
> 
> Fixes: 34f14b1519715d47d879 (2024-03-11, "ARM: i.MX8MP: add König+Bauer AlphaJet board")
> Rubberducked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts b/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
> index 3f958ddf78e8..198fe1379a05 100644
> --- a/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
> +++ b/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
> @@ -7,7 +7,7 @@
>  
>  / {
>  	model = "Koenig+Bauer Alphajet";
> -	compatible = "koenigbauer,alphajet", "congatec,qmxp8p", "fsl,imx8mp";
> +	compatible = "koenigbauer,alphajet", "congatec,qmx8p", "fsl,imx8mp";

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

>  
>  	display {
>  		compatible = "innolux,g101ice-l01";

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2024-04-30 12:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 10:23 Roland Hieber
2024-04-30 12:05 ` Ahmad Fatoum [this message]
2024-05-03  7:22 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b63e960-845b-4213-873c-da9749f82a64@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox