From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 04 Jan 2024 14:12:18 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rLNWF-003Y4B-0N for lore@lore.pengutronix.de; Thu, 04 Jan 2024 14:12:18 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLNWE-00019J-0K for lore@pengutronix.de; Thu, 04 Jan 2024 14:12:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U54bWrJuDSlDV839Zio1G8CL06jomUS2XuSlb+NN7xM=; b=Ptijd+Jg1NTMxX1qndrUA9+BoF PJAPkLQ598uX5EKVkFdD50zntVjBjl0vOFMB/BUATdLtgaKr2MWq4LmEGa4qg7JUCdpeIbPKsdKBl ccw6AQd+5bxpyTCS4aY/AgNyEvSd2Wh7F2eeloJOgxIldu+mDf7mTa6x5cPxxoYMkMv6HziCmbBbo g2jE97ZU/tpf/absg77rAhm1isvyB2clATOhhWWv+B7NCiY9SvOJi0n8CLVPGYPmOlLMmLjTO+gkg TFwI/7KQLyczCiZCvEhHeyXdvsddFq2hHE3nF7mCdfhoVTc+DdZGhsPcCjkA6gtaHzpNJZCTcaghq f3D53oww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLNVC-00E5bo-2c; Thu, 04 Jan 2024 13:11:14 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLNV9-00E5aT-02 for barebox@lists.infradead.org; Thu, 04 Jan 2024 13:11:12 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rLNV6-0000qm-70; Thu, 04 Jan 2024 14:11:08 +0100 Message-ID: <9c6aac67-08c8-43da-8c9f-08df06e35b68@pengutronix.de> Date: Thu, 4 Jan 2024 14:11:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sascha Hauer Cc: barebox@lists.infradead.org, Ahmad Fatoum References: <20231220104739.10700-1-bst@pengutronix.de> <20240102091538.GW1318922@pengutronix.de> <20240102113241.GB1318922@pengutronix.de> From: Bastian Krause In-Reply-To: <20240102113241.GB1318922@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_051111_113684_FF7DD2A4 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2] i2c: add pmic_reg_read() for PBL use X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 1/2/24 12:32, Sascha Hauer wrote: > On Tue, Jan 02, 2024 at 10:15:38AM +0100, Sascha Hauer wrote: >> On Wed, Dec 20, 2023 at 11:47:39AM +0100, Bastian Krause wrote: >>> Add a common PMIC read function to PBL which allows easy porting of >>> U-Boot's pmic_reg_read() in lowlevel board code. >>> >>> Signed-off-by: Bastian Krause >>> --- >>> Changes since (implicit) v1: >>> - make function static inline as suggested by Ahmad >>> - change void *buf to u32 *val to resemble's U-Boot's pmic_reg_read() as >>> suggested by Ahmad >>> --- >>> include/pbl/pmic.h | 24 ++++++++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >>> diff --git a/include/pbl/pmic.h b/include/pbl/pmic.h >>> index 0f882c5649d..4eeee31d46c 100644 >>> --- a/include/pbl/pmic.h >>> +++ b/include/pbl/pmic.h >>> @@ -9,6 +9,30 @@ struct pmic_config { >>> u8 val; >>> }; >>> >>> +static inline void pmic_reg_read(struct pbl_i2c *i2c, int addr, u8 reg, u32 *val) >> >> I didn't notice there is a v2 when replying to v1, so here again: >> >> Why not make *val a u8 *? > > I renamed this to pmic_reg_read8() and changed the data type to u8 *, > see the patch I just sent. Works for me, thanks! Bastian > > Sascha > >> >> Sascha >> >>> +{ >>> + int ret; >>> + u8 buf[1]; >>> + struct i2c_msg msg[] = { >>> + { >>> + .addr = addr, >>> + .buf = ®, >>> + .len = 1, >>> + }, { >>> + .addr = addr, >>> + .flags = I2C_M_RD, >>> + .buf = buf, >>> + .len = 1, >>> + }, >>> + }; >>> + >>> + ret = pbl_i2c_xfer(i2c, msg, ARRAY_SIZE(msg)); >>> + if (ret != ARRAY_SIZE(msg)) >>> + pr_err("Failed to read from pmic@%x: %d\n", addr, ret); >>> + >>> + *val = buf[0]; >>> +} >>> + >>> static void pmic_reg_write(struct pbl_i2c *i2c, int addr, u8 reg, u8 val) >>> { >>> int ret; >>> -- >>> 2.39.2 >>> >>> >>> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |