From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Cameron Ferguson <cameron.bare86@gmail.com>, barebox@lists.infradead.org
Subject: Re: Small tweak to get ACPI watchdog working (iTCO)
Date: Wed, 29 Jan 2020 19:00:46 +0100 [thread overview]
Message-ID: <9c6ecb91-ab54-c7c7-813e-394bd71e4506@pengutronix.de> (raw)
In-Reply-To: <CAEKVsgbBXKcmg2rRFZ16VSNLnu+7C+pJH-GomExFxz9o_+bqdA@mail.gmail.com>
On 1/29/20 6:55 PM, Cameron Ferguson wrote:
>> In the code you sent last time, it said that your addresses
>> are IORESOURCE_IO. These are I/O ports, not memory-mapped ports,
>> so you can't dereference a pointer and access them, but instead you
>> have to use port I/O instruction, which in barebox and Linux is
>> the out[bwl] family of functions.
>
>
> I got it working.
Great!
Clean it up and send patches! :-)
>
> I included the header file "arch/x86/include/asm/io.h" and so I
> thought I was using the right functions for IO operations on ports,
> however it turns out that "linux/io.h" was being included before the
> aforementioned header file, and so "inl" and outl" were already
> defined with generic implementations instead of as specific to x86.
We don't have a linux/io.h. Include order shouldn't matter, if it does,
that's a bug you can send a patch to fix this as well.
>
> It's working. The watchdog will reboot if the Linux kernel freezes on boot up.
>
> Thank you for your help, Ahmad, I wouldn't have looked further into
> the IO headers if you hadn't pointed me in the right direction.
Cheers
Ahamd
>
> Cameron
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-01-29 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEKVsgZHZR2b28wcMcpac4Qa3KebrXMRf14STZ8GCum0NmnLgg@mail.gmail.com>
2020-01-28 15:19 ` Cameron Ferguson
2020-01-29 8:36 ` Cameron Ferguson
2020-01-29 11:20 ` Ahmad Fatoum
2020-01-29 16:07 ` Cameron Ferguson
2020-01-29 16:57 ` Cameron Ferguson
2020-01-29 16:57 ` Ahmad Fatoum
2020-01-29 17:55 ` Cameron Ferguson
2020-01-29 18:00 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c6ecb91-ab54-c7c7-813e-394bd71e4506@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=cameron.bare86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox