mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Martin Hofmann <martin.hofmann@mni.thm.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: No default env without Barebox wanting to load from persistant storage
Date: Tue, 30 Oct 2018 09:50:52 +0100	[thread overview]
Message-ID: <9cb77896-47c9-cf64-5969-df0532a1a6e6@mni.thm.de> (raw)
In-Reply-To: <20181030073347.53i6ynwsfrp2aug3@pengutronix.de>

On 10/30/18 8:33 AM, Sascha Hauer wrote:
> On Tue, Oct 30, 2018 at 07:57:23AM +0100, Martin Hofmann wrote:
>>
>>
>> On 10/29/18 2:53 PM, Sascha Hauer wrote:
>>> Hi Martin,
>>>
>>> On Sun, Oct 28, 2018 at 04:24:13PM +0100, Martin Hofmann wrote:
>>>> Hello everyone,
>>>>
>>>> I am currently working on a Barebox port for our own home made architecture
>>>> used for educational purpose.
>>>>
>>>> The port can be found under github.com/mh0fmann/eco32-barebox and starts
>>>> being used.
>>>>
>>>> Our architecture does not have any kind of nand or nor flash that can be
>>>> added used for /dev/env0 to store a environment in it but we still want to
>>>> use a default compile in enivornment.
>>>>
>>>> In oderder to use that one is in the in the need to activate
>>>> CONFIG_ENV_HANDLING which alaways wants to load a environment from
>>>> /dev/env0.
>>>>
>>>> So the question is - is it not possible to just use a compile in default env
>>>> without the need that barebox wants to load another env from somewhere else
>>>> or did i miss something on the way?
>>>
>>> Indeed this a usecase I never thought of and is not officially
>>> supported. However, a
>>>
>>> 	default_environment_path_set(NULL);
>>>
>>> Should have the desired effect.
>>>
>>> Sascha
>>>
>>
>> Hello Sascha,
>>
>> thanks for the reply!
>>
>> But are your sure that setting the default evironment path to NULL would
>> have the said effect?
>>
>> It will then pass the NULL filepath pointer to open in load_envfs?
>> Which in return also doesn't check for if the argumnt is NULL or not..
>>
>> Looks like barebox crashes in this case
> 
> This most likely goes down to:
> 
> | commit c6bdbf6e93a11227f91fbf15b7a36dceb60c526d
> | Author: Sascha Hauer <s.hauer@pengutronix.de>
> | Date:   Fri Sep 21 14:18:33 2018 +0200
> | 
> |     environment: Allow default env path to be NULL
> |     
> |     Several places assume that the default environment path cannot be NULL.
> |     Allow NULL here without crashing.
> |     
> |     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> 
> This commit is in current master, so it'll be in the next release.
> 
> Sascha
> 

Hello Sascha,

thanks for the info. I guess I will wait for the next release then.
Until it is released we will just ignore that message.

Greetings,
Martin

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-10-30  8:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-28 15:24 Martin Hofmann
2018-10-29 13:53 ` Sascha Hauer
2018-10-30  6:57   ` Martin Hofmann
2018-10-30  7:33     ` Sascha Hauer
2018-10-30  8:50       ` Martin Hofmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cb77896-47c9-cf64-5969-df0532a1a6e6@mni.thm.de \
    --to=martin.hofmann@mni.thm.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox