mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Belisko Marek <marek.belisko@gmail.com>
To: barebox@lists.infradead.org
Subject: RFC: change map_base type
Date: Wed, 24 Nov 2010 13:39:03 +0100	[thread overview]
Message-ID: <AANLkTi=JJf6HyktGrsS5gscd3Yf1wc2Ef2Bb8hbrmEqd@mail.gmail.com> (raw)

Hi,

fist sparse patches was accepted but doesn't fix all problems.

There is still a lot of sparse problems which complain about incorrect type
in functions read(bwl)/writ(bwl). Over whole codebase to this
functions are passed
u_long or u_int types which is not correct.

e.g. in serial drivers is used for access to registers:
writeb(0x07, dev->map_base + UFCON);

In my opinion it make no sense to use:
writeb(0x07, IOMEM(dev->map_base + UFCON));

Instead change map_base type in include/driver.h to void __iomem *map_base
which should fix a lot sparse problems.
Then only board code when device is initialized use: .map_base =
IOMEM(0x00000...)

Make it sense or there is not necessary to touch it or other way?

Thanks for comments,

marek


-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2010-11-24 12:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 12:39 Belisko Marek [this message]
2010-11-24 14:48 ` Jean-Christophe PLAGNIOL-VILLARD
2010-11-24 20:09   ` Belisko Marek
2010-11-25  8:29     ` Sascha Hauer
2010-11-25 11:23     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=JJf6HyktGrsS5gscd3Yf1wc2Ef2Bb8hbrmEqd@mail.gmail.com' \
    --to=marek.belisko@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox