Re: RFC: change map_base type

[Belisko Marek <marek.belisko@gmail.com>]

On Wed, Nov 24, 2010 at 3:48 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> On 13:39 Wed 24 Nov     , Belisko Marek wrote:
>> Hi,
>>
>> fist sparse patches was accepted but doesn't fix all problems.
>>
>> There is still a lot of sparse problems which complain about incorrect type
>> in functions read(bwl)/writ(bwl). Over whole codebase to this
>> functions are passed
>> u_long or u_int types which is not correct.
>>
>> e.g. in serial drivers is used for access to registers:
>> writeb(0x07, dev->map_base + UFCON);
>>
>> In my opinion it make no sense to use:
>> writeb(0x07, IOMEM(dev->map_base + UFCON));
>>
>> Instead change map_base type in include/driver.h to void __iomem *map_base
>> which should fix a lot sparse problems.
>> Then only board code when device is initialized use: .map_base =
>> IOMEM(0x00000...)
>>
>> Make it sense or there is not necessary to touch it or other way?
> it's a ressources so it's the right type as in the kernel
>
> the driver need to cast based on it's need
>
> as done in linux
You are right. Linus type for map_base is same like in barebox.
Anyway if you pass some resource to driver it is always re-mapped and
used remapped value over all code for IO access.

Maybe best would be cast map_base in probe function of driver with IOMEM() macro
and this value store in driver structure and use. Good idea?
>
> remember with the multi-ressource it's not anymore a base address you pass
> but any data
>
> Best Regards,
> J.
>

thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox