mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier.adi@gmail.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] MAKEALL: make it generic
Date: Fri, 24 Sep 2010 14:13:10 -0400	[thread overview]
Message-ID: <AANLkTimAbBNcJEbJPSVXhHMBmgFUyh7wAgmYPguDg1T5@mail.gmail.com> (raw)
In-Reply-To: <1285350271-18637-1-git-send-email-plagnioj@jcrosoft.com>

On Fri, Sep 24, 2010 at 13:44, Jean-Christophe PLAGNIOL-VILLARD wrote:
> +if [ ! "${LOGDIR}" ] ; then
> +       LOGDIR="LOG"
> +fi

simpler syntax:
: ${LOGDIR:=LOG}

> +if [ ! "${BUILDDIR}" ] ; then
> +       BUILDIR="makeall_buildir"
>  fi

: ${BUILDDIR:=makeall_builddir}

i think your patch misses a "d" here at least ...

> +CROSS_COMPILE_arm=/opt/arm-2007q3/bin/arm-none-linux-gnueabi-
> +CROSS_COMPILE_m68k=m68k-uclinux-
> +CROSS_COMPILE_blackfin=/opt/uClinux/bfin-linux-uclibc/bin/bfin-linux-uclibc-
> +CROSS_COMPILE_ppc=/opt/powerpc/bin/powerpc-unknown-linux-gnu-
> +CROSS_COMPILE_sandbox=/usr/bin/
> +CROSS_COMPILE_x86=/usr/bin/

i dont think hardcoding paths is a good idea, and bfin-linux-uclibc-
might not work.  so bfin-uclinux- might be better.
-mike

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-09-24 18:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24 17:44 Jean-Christophe PLAGNIOL-VILLARD
2010-09-24 18:13 ` Mike Frysinger [this message]
2010-09-25  4:14   ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-25  5:10     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimAbBNcJEbJPSVXhHMBmgFUyh7wAgmYPguDg1T5@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox