Re: [PATCH] common: add custom autoboot_abort_key

[SCHNEIDER Johannes <johannes.schneider@leica-geosystems.com>]

Hoi,

> 
> Having a custom key to stop autoboot is generally fine. Defining the key
> at compile time not so.
>

i was at first wondering "then how are we supposed to configure it" but looking
through the code how 'global_autoboot_abort_key=1' for ctrl-c was nowhere to be
found in the codebase, i realized that the <any> is just the
global.autoboot_abort_key no-one ever set to anything else :-D

... and i should have set it up in a way that you'd feed barebox an
env/nv/autoboot_abort_key
with 'any', 'ctrl-c' or the one key -- right?

>
> Instead we could convert autoboot_abort_key from
> globalvar_add_simple_enum() to dev_add_param_string(&global_device,...)
> the set function could then accept "any", "ctrl-c" or any other single
> digit string.
>

got it - i'll rework it and send out a v2 :-)

> Sascha
> 
> --


gruß
Johannes