From: "Premi, Sanjeev" <premi@ti.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: RE: [PATCH v2] omap: Unify run_shell() in xload configuration
Date: Wed, 12 Oct 2011 15:41:00 +0530 [thread overview]
Message-ID: <B85A65D85D7EB246BE421B3FB0FBB5930257A576C4@dbde02.ent.ti.com> (raw)
In-Reply-To: <20111011203011.GJ18064@game.jcrosoft.org>
> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@jcrosoft.com]
> Sent: Wednesday, October 12, 2011 2:00 AM
> To: Premi, Sanjeev
> Cc: barebox@lists.infradead.org
> Subject: Re: [PATCH v2] omap: Unify run_shell() in xload configuration
>
> > -
> > - if (!func) {
> > - printf("booting failed\n");
> > - while (1);
> > - }
> > -
> > - shutdown_barebox();
> > - func();
> > -
> > - while (1);
> > -}
> > -#endif
> > diff --git a/arch/arm/mach-omap/Makefile
> b/arch/arm/mach-omap/Makefile
> > index 7204746..07bf30a 100644
> > --- a/arch/arm/mach-omap/Makefile
> > +++ b/arch/arm/mach-omap/Makefile
> > @@ -25,4 +25,5 @@ obj-$(CONFIG_ARCH_OMAP3) += omap3_core.o
> omap3_generic.o
> > obj-$(CONFIG_ARCH_OMAP4) += omap4_generic.o omap4_clock.o
> > obj-$(CONFIG_OMAP3_CLOCK_CONFIG) += omap3_clock_core.o
> omap3_clock.o
> > obj-$(CONFIG_OMAP_GPMC) += gpmc.o devices-gpmc-nand.o
> > -obj-y += gpio.o xload.o
> > +obj-$(CONFIG_SHELL_NONE) += xload.o
> > +obj-y += gpio.o
> > diff --git a/arch/arm/mach-omap/xload.c b/arch/arm/mach-omap/xload.c
> > index 216b9b5..ac859fa 100644
> > --- a/arch/arm/mach-omap/xload.c
> > +++ b/arch/arm/mach-omap/xload.c
> > @@ -52,3 +52,39 @@ void *omap_xload_boot_mmc(void)
> >
> > return buf;
> > }
> > +
> > +/*
> > + * Replaces the default shell in xload configuration
> > + */
> > +int run_shell(void)
> > +{
> > + int (*func)(void) = NULL;
> > +
> > +#if defined(CONFIG_ARCH_OMAP3)
> > + switch (omap3_bootsrc())
> > +#elif defined(CONFIG_ARCH_OMAP4)
> > + switch (omap4_bootsrc())
> > +#endif
> I really don't like this
>
> please create a small local station like this to manage the OMAPx
>
> static u32 omap_bootsrc(void)
> {
> #if defined(CONFIG_ARCH_OMAP3)
> return omap3_bootsrc())
> #elif defined(CONFIG_ARCH_OMAP4)
> return omap4_bootsrc())
> switch (omap4_bootsrc())
> #endif
> }
Actually I wanted to do this... just postponed it long enough to forget :(
Will do this now.
~sanjeev
>
> and then
> switch (omap_bootsrc()) {
>
>
> Best Regards,
> J.
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-10-12 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 15:23 Sanjeev Premi
2011-10-11 20:30 ` Jean-Christophe PLAGNIOL-VILLARD
2011-10-12 10:11 ` Premi, Sanjeev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B85A65D85D7EB246BE421B3FB0FBB5930257A576C4@dbde02.ent.ti.com \
--to=premi@ti.com \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox