mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512
Date: Sun, 29 Mar 2015 04:07:23 +0800	[thread overview]
Message-ID: <B98B8DDF-B83C-42E7-A8CD-E90DE16DE567@jcrosoft.com> (raw)
In-Reply-To: <1427473384-30472-1-git-send-email-antonynpavlov@gmail.com>

please write a better commit

it’s a coding style issue not a fixup
and here more a typo

Fixup means a BUG

Best Regards,
J.
> On Mar 28, 2015, at 12:23 AM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> 
> ---
> commands/hashsum.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/commands/hashsum.c b/commands/hashsum.c
> index e2dc70e..8d3694f 100644
> --- a/commands/hashsum.c
> +++ b/commands/hashsum.c
> @@ -36,7 +36,7 @@ static int do_hash(char *algo, int argc, char *argv[])
> 	size_t keylen = 0;
> 	int opt, ret;
> 
> -	while((opt = getopt(argc, argv, "h:")) > 0) {
> +	while ((opt = getopt(argc, argv, "h:")) > 0) {
> 		switch(opt) {
> 		case 'h':
> 			key = optarg;
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-03-28 20:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 16:23 Antony Pavlov
2015-03-28 20:07 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2015-03-29  8:04   ` Antony Pavlov
2015-04-02  7:11     ` Holger Schurig
2015-04-02  7:27       ` Antony Pavlov
2015-04-03  6:15       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B98B8DDF-B83C-42E7-A8CD-E90DE16DE567@jcrosoft.com \
    --to=plagnioj@jcrosoft.com \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox