From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.eu2.fugro.com ([46.34.88.152]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WGrwr-0006qQ-Q9 for barebox@lists.infradead.org; Fri, 21 Feb 2014 15:23:34 +0000 Content-class: urn:content-classes:message MIME-Version: 1.0 Date: Fri, 21 Feb 2014 16:23:07 +0100 Message-ID: From: "Hattink, Tjalling [FINT]" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH] mtd: nand: Do not automatically set SUBPAGE_READ flag To: barebox@lists.infradead.org The default nand_read_subpage implementation returns -ENOSUPP, so if you use a large nand chip without a specific read_subpage implementation the read operations will always fail. This functionaliy can be restored when a proper nand_read_subpage is implemented for the default driver. Signed-off-by: Tjalling Hattink --- drivers/mtd/nand/nand_base.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 54d8ba3..bfd695b 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -3562,10 +3562,6 @@ int nand_scan_tail(struct mtd_info *mtd) /* Invalidate the pagebuffer reference */ chip->pagebuf = -1; - /* Large page NAND with SOFT_ECC should support subpage reads */ - if ((chip->ecc.mode == NAND_ECC_SOFT) && (chip->page_shift > 9)) - chip->options |= NAND_SUBPAGE_READ; - /* Fill in remaining MTD driver data */ mtd->type = MTD_NANDFLASH; mtd->flags = (chip->options & NAND_ROM) ? MTD_CAP_ROM : -- 1.8.3.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox