Re: [PATCH 2/2] pbl: factorise linux/decompress/mm.h inclusion

[Antony Pavlov <antonynpavlov@gmail.com>]

On 5 February 2013 12:57, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Tue, Feb 05, 2013 at 02:36:36AM +0400, Antony Pavlov wrote:
>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>> ---
>>  lib/decompress_inflate.c |    1 -
>>  lib/decompress_unlzo.c   |    1 -
>>  pbl/decomp.c             |    2 ++
>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/decompress_inflate.c b/lib/decompress_inflate.c
>> index 5c1ebb6..526d6a1 100644
>> --- a/lib/decompress_inflate.c
>> +++ b/lib/decompress_inflate.c
>> @@ -4,7 +4,6 @@
>>  /* prevent inclusion of _LINUX_KERNEL_H in pre-boot environment: lots
>>   * errors about console_printk etc... on ARM */
>>  #define _LINUX_KERNEL_H
>> -#include <linux/decompress/mm.h>
>>
>>  #include "zlib_inflate/inftrees.c"
>>  #include "zlib_inflate/inffast.c"
>> diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c
>> index 1b2dc9d..2b0fbed 100644
>> --- a/lib/decompress_unlzo.c
>> +++ b/lib/decompress_unlzo.c
>> @@ -32,7 +32,6 @@
>>  #include <xfuncs.h>
>>
>>  #ifdef STATIC
>> -#include <linux/decompress/mm.h>
>>  #include "lzo/lzo1x_decompress.c"
>>  #else
>>  #include <malloc.h>
>> diff --git a/pbl/decomp.c b/pbl/decomp.c
>> index aa6a31e..17fc01e 100644
>> --- a/pbl/decomp.c
>> +++ b/pbl/decomp.c
>> @@ -10,6 +10,8 @@
>>
>>  #define STATIC static
>>
>> +#include <linux/decompress/mm.h>
>> +
>
> Any special reason for this patch? Normally the #include is in the file
> requiring the declarations from the file. In this case decompress_* need
> linux/decompress/mm.h, not pbl/decomp.c.

There is no special reason for this patch, just factorisation. If you
don't like this type of factorisation you can drop this patch :)

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox