versatilepb board support is broken

versatilepb board support is broken

[Antony Pavlov]

Hi!

The following patch breaks qemu versatilepb board support:

c0ff8f7f47fa10b2e683cb0452f659c97aec186f
    versatile: switch to add_generic_device

The problem is in serial port initialization.

As versatilepb use only one serial port, this hack make barebox workable
again (of course it is not a good solution).

--- a/arch/arm/mach-versatile/core.c
+++ b/arch/arm/mach-versatile/core.c
@@ -156,6 +156,7 @@ void versatile_register_uart(unsigned id)
 	switch (id) {
 	case 0:
 		start = VERSATILE_UART0_BASE;
+		vpb_clk_create(&ref_clk_24, "uart-pl0110");
 		break;
 	case 1:
 		start = VERSATILE_UART1_BASE;
@@ -171,7 +172,6 @@ void versatile_register_uart(unsigned id)
 	}
 	dev = add_generic_device("uart-pl011", id, NULL, start, 4096,
 			   IORESOURCE_MEM, NULL);
-	vpb_clk_create(&ref_clk_24, dev_name(dev));
 }

 void __noreturn reset_cpu (unsigned long ignored)

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: versatilepb board support is broken

[Jean-Christophe PLAGNIOL-VILLARD]

On 23:49 Mon 08 Aug     , Antony Pavlov wrote:
> Hi!
> 
> The following patch breaks qemu versatilepb board support:
> 
> c0ff8f7f47fa10b2e683cb0452f659c97aec186f
>     versatile: switch to add_generic_device
> 
> The problem is in serial port initialization.
> 
> As versatilepb use only one serial port, this hack make barebox workable
> again (of course it is not a good solution).
> 
> --- a/arch/arm/mach-versatile/core.c
> +++ b/arch/arm/mach-versatile/core.c
> @@ -156,6 +156,7 @@ void versatile_register_uart(unsigned id)
>  	switch (id) {
>  	case 0:
>  		start = VERSATILE_UART0_BASE;
I found the issue too

but you need to fix all uart

see my patch

Best Regards,
J.
> +		vpb_clk_create(&ref_clk_24, "uart-pl0110");
>  		break;
>  	case 1:
>  		start = VERSATILE_UART1_BASE;
> @@ -171,7 +172,6 @@ void versatile_register_uart(unsigned id)
>  	}
>  	dev = add_generic_device("uart-pl011", id, NULL, start, 4096,
>  			   IORESOURCE_MEM, NULL);
> -	vpb_clk_create(&ref_clk_24, dev_name(dev));
>  }
> 
>  void __noreturn reset_cpu (unsigned long ignored)
> 
> -- 
> Best regards,
>   Antony Pavlov
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: versatilepb board support is broken

[Antony Pavlov]

On 9 August 2011 01:05, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> On 23:49 Mon 08 Aug     , Antony Pavlov wrote:
>> Hi!
>>
>> The following patch breaks qemu versatilepb board support:
>>
>> c0ff8f7f47fa10b2e683cb0452f659c97aec186f
>>     versatile: switch to add_generic_device
>>
>> The problem is in serial port initialization.
>>
>> As versatilepb use only one serial port, this hack make barebox workable
>> again (of course it is not a good solution).
>>
>> --- a/arch/arm/mach-versatile/core.c
>> +++ b/arch/arm/mach-versatile/core.c
>> @@ -156,6 +156,7 @@ void versatile_register_uart(unsigned id)
>>       switch (id) {
>>       case 0:
>>               start = VERSATILE_UART0_BASE;
> I found the issue too
>
> but you need to fix all uart

It was not a fix, it was a DIRTY HACK (but it was very illustrative). :)))

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: versatilepb board support is broken

[Jean-Christophe PLAGNIOL-VILLARD]

On 15:22 Wed 10 Aug     , Antony Pavlov wrote:
> On 9 August 2011 01:05, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
> > On 23:49 Mon 08 Aug     , Antony Pavlov wrote:
> >> Hi!
> >>
> >> The following patch breaks qemu versatilepb board support:
> >>
> >> c0ff8f7f47fa10b2e683cb0452f659c97aec186f
> >>     versatile: switch to add_generic_device
> >>
> >> The problem is in serial port initialization.
> >>
> >> As versatilepb use only one serial port, this hack make barebox workable
> >> again (of course it is not a good solution).
> >>
> >> --- a/arch/arm/mach-versatile/core.c
> >> +++ b/arch/arm/mach-versatile/core.c
> >> @@ -156,6 +156,7 @@ void versatile_register_uart(unsigned id)
> >>       switch (id) {
> >>       case 0:
> >>               start = VERSATILE_UART0_BASE;
> > I found the issue too
> >
> > but you need to fix all uart
> 
> It was not a fix, it was a DIRTY HACK (but it was very illustrative). :)))
so please put [RFC xxx] or any thing slse in the subject that we see it's not
a patch to apply

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox