From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 1/5] MIPS: add common header file for DEBUG_LL via NS16550
Date: Fri, 11 May 2012 13:11:51 +0400 [thread overview]
Message-ID: <CAA4bVAGFKWvkxTm+u6ZkH8Z4eRU-hoW8-n+rKi0cJqxPZnNvjQ@mail.gmail.com> (raw)
In-Reply-To: <20120511072013.GZ27341@pengutronix.de>
On 11 May 2012 11:20, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Thu, May 10, 2012 at 01:32:06PM +0400, Antony Pavlov wrote:
>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>> ---
>> arch/mips/include/debug_ll_common.h | 40 +++++++++++++++++++++++++++++++++++
>> 1 file changed, 40 insertions(+)
>> create mode 100644 arch/mips/include/debug_ll_common.h
>>
>> diff --git a/arch/mips/include/debug_ll_common.h b/arch/mips/include/debug_ll_common.h
>
> Does that mean that every mips has a ns16550? If not the file should
> have 16550 in its name.
You are right!
Can we use the header like this for the other architectures (ARM etc) too?
> Sascha
>
>> new file mode 100644
>> index 0000000..7c26f54
>> --- /dev/null
>> +++ b/arch/mips/include/debug_ll_common.h
>> @@ -0,0 +1,40 @@
>> +/*
>> + * Copyright (C) 2012 Antony Pavlov <antonynpavlov@gmail.com>
>> + *
>> + * This file is part of barebox.
>> + * See file CREDITS for list of people who contributed to this project.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2
>> + * as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
>> + */
>> +
>> +/** @file
>> + * This file contains declaration for early output support
>> + */
>> +#ifndef __INCLUDE_ARCH_DEBUG_LL_COMMON_H__
>> +#define __INCLUDE_ARCH_DEBUG_LL_COMMON_H__
>> +
>> +#include <asm/io.h>
>> +
>> +#define rbr (0 << DEBUG_LL_UART_SHIFT)
>> +#define lsr (5 << DEBUG_LL_UART_SHIFT)
>> +
>> +#define LSR_THRE 0x20 /* Xmit holding register empty */
>> +
>> +static __inline__ void putc(char ch)
>> +{
>> + while (!(__raw_readb((u8 *)DEBUG_LL_UART_ADDR + lsr) & LSR_THRE));
>> + __raw_writeb(ch, (u8 *)DEBUG_LL_UART_ADDR + rbr);
>> +}
>> +
>> +#endif /* __INCLUDE_ARCH_DEBUG_LL_COMMON_H__ */
>> --
>> 1.7.10
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-11 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 9:32 [RFC 0/5] MIPS: add XBurst processor family support Antony Pavlov
2012-05-10 9:32 ` [RFC 1/5] MIPS: add common header file for DEBUG_LL via NS16550 Antony Pavlov
2012-05-11 7:20 ` Sascha Hauer
2012-05-11 9:11 ` Antony Pavlov [this message]
2012-05-10 9:32 ` [RFC 2/5] MIPS: add XBurst processor family support Antony Pavlov
2012-05-10 9:32 ` [RFC 3/5] MISP: XBurst: add JZ4755 CPU support Antony Pavlov
2012-05-10 9:32 ` [RFC 4/5] MIPS: XBurst: add Ritmix RZX-50 board support Antony Pavlov
2012-05-10 16:31 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-10 9:32 ` [RFC 5/5] MIPS: add defconfig for Ritmix RZX-50 board Antony Pavlov
2012-05-11 7:26 ` [RFC 0/5] MIPS: add XBurst processor family support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA4bVAGFKWvkxTm+u6ZkH8Z4eRU-hoW8-n+rKi0cJqxPZnNvjQ@mail.gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox